-
Notifications
You must be signed in to change notification settings - Fork 452
Send user agent info as a new feature extension to server #2848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2848 +/- ##
============================================
+ Coverage 56.35% 56.39% +0.04%
- Complexity 4531 4550 +19
============================================
Files 151 151
Lines 34445 34494 +49
Branches 5741 5751 +10
============================================
+ Hits 19410 19454 +44
- Misses 12415 12421 +6
+ Partials 2620 2619 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
David-Engel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. Otherwise, LGTM.
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
d919144
ab3cc28
Description:
By enhancing telemetry for SQL drivers, we can achieve a more nuanced understanding of the operating environments in use. This capability enables us to make strategic decisions about testing and support, ultimately improving our efficiency and reducing costs. Adopting a structured and extensible approach to telemetry collection will ensure we gather the most relevant and useful data, facilitating continuous improvement in our processes.
The user agent information will be transported to the SQL Server via a new TDS Feature Extension (FE) in the LOGIN7 TDS message:
Name: USERAGENT
Identifier: 0x10
Data Length: max 256 bytes
Data: + UCS-2 encoded String
User agent string format:
<user agent version>|<driver type>|<driver version>|<os type>|<os version>|<architecture>|<runtime>Sample
1|MS-JDBC|13.2.0|Windows|Windows 10.0.22600.0|amd64|OpenJDK 64-Bit Server VM 21.0.4+7-LTSTesting:
-Added a new test to validate the generated user agent string max length
-Verified with SQL databases that are both disabled and enabled with accepting and handling this new user agent FE.
-All existing test cases exercise this code path since each login packet will include this new feature extension.