-
Notifications
You must be signed in to change notification settings - Fork 439
Introducing Performance Loggers #2706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
machavan
wants to merge
6
commits into
main
Choose a base branch
from
dev/machavan/perflogger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,211
−827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
============================================
+ Coverage 51.49% 52.23% +0.73%
- Complexity 4060 4139 +79
============================================
Files 149 151 +2
Lines 34136 34340 +204
Branches 5700 5727 +27
============================================
+ Hits 17580 17937 +357
+ Misses 14090 13898 -192
- Partials 2466 2505 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
David-Engel
reviewed
Jul 16, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Aug 28, 2025
src/main/java/com/microsoft/sqlserver/jdbc/PerformanceLogCallback.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/PerformanceLogCallback.java
Outdated
Show resolved
Hide resolved
Ananya2
reviewed
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a foundational change for introducing performance loggers which can be used tracking performance of various activities within the mssql-jdbc driver e.g. connection time, login time, token acquisition time etc.
A new java.util.Logging logger
com.microsoft.sqlserver.jdbc.PerformanceMetrics.Connection
is introduced here which can be subscribed to by applications.More loggers such as
com.microsoft.sqlserver.jdbc.PerformanceMetrics.Statement
will be introduced in future.Various performance activities to be tracked are defined in a PerformanceActivity Enum which will be amended with new additions in future.
Testing:
-Manual testing of new logger functionality.
-All existing tests ensure testing of newly added code.