Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export msquic include install dir #4725

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 31, 2024

Description

This PR ensures that the exported CMake target carries the include directories property which is necessary for accessing the installed headers.
The location corresponds to the destination in

install(FILES ${PUBLIC_HEADERS} DESTINATION include)

Testing

This is backported from the vcpkg port of msquic. In vcpkg, the exported config is consumed by port msh3.

Documentation

No impact AFAICT. CMake usage is not covered at all.

FTR vcpkg's (tested) usage notice is:

msquic provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(msquic CONFIG REQUIRED)
  target_link_libraries(main PRIVATE msquic::msquic)

which is pretty much what is expected for Modern CMake. (But the vcpkg port comes with more patches.)

@dg0yt dg0yt requested a review from a team as a code owner December 31, 2024 08:38
@nibanks nibanks enabled auto-merge (squash) December 31, 2024 13:57
@nibanks nibanks added Area: Build external Proposed by non-MSFT labels Dec 31, 2024
@nibanks nibanks merged commit b6ebb83 into microsoft:main Dec 31, 2024
471 of 473 checks passed
@dg0yt dg0yt deleted the export-include-dir branch December 31, 2024 14:25
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (10f2487) to head (cd126f5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4725      +/-   ##
==========================================
- Coverage   87.17%   85.71%   -1.47%     
==========================================
  Files          56       56              
  Lines       17363    17363              
==========================================
- Hits        15137    14882     -255     
- Misses       2226     2481     +255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants