Export msquic include install dir #4725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the exported CMake target carries the include directories property which is necessary for accessing the installed headers.
The location corresponds to the destination in
msquic/src/bin/CMakeLists.txt
Line 270 in 10f2487
Testing
This is backported from the vcpkg port of msquic. In vcpkg, the exported config is consumed by port msh3.
Documentation
No impact AFAICT. CMake usage is not covered at all.
FTR vcpkg's (tested) usage notice is:
which is pretty much what is expected for Modern CMake. (But the vcpkg port comes with more patches.)