Kernel Platform Worker Support

[nibanks]

Description

Extracts/refactors some of the code in #4023 to support platform worker threads, which is a prereq for kernel xdp support.

Testing

CI/CD

Documentation

N/A

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (ba795e0) to head (fd58cee).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4605      +/-   ##
==========================================
- Coverage   87.38%   85.52%   -1.86%     
==========================================
  Files          56       56              
  Lines       17400    17400              
==========================================
- Hits        15205    14882     -323     
- Misses       2195     2518     +323     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nibanks]

Looks like the kernel BVTs are crashing. I will try to investigate later.

[nibanks]

Something seems broken in netperf runs. I can't tell if it's because of this or not. Needs to be investigated before merging.

[ami-GS]

Is the netperf result reliable? wsk related failure is really few. others are more

[nibanks]

Converted this back to draft, because we need to switch to using NtCreateIoCompletion, NtSetIoCompletion, and NtRemoveIoCompletionEx.

[mtfriesen]

Converted this back to draft, because we need to switch to using NtCreateIoCompletion, NtSetIoCompletion, and NtRemoveIoCompletionEx.

I suggest using the Zw variants for KM, unless QUIC is calling on behalf of the user mode thread calling QUIC, and all in the same thread context.

[ami-GS]

Launching threads here can be waste of resources? because pure winkernel doesn't use them.
Should be put in raw datapath initialization? but no need to fix in this PR I think.

[ami-GS]

Because platform_winkernel.c copies from zwapi.h, quic_platform_winkernel.h does same.

[ami-GS]

msquic/src/core/worker.c

Line 174 in 101f6b9

CxPlatEventWaitForever(Worker->Done);

RegistrationClose doesn't return by here

Edit:
QuicWorkerLoop is not called for some reason

[nibanks]

msquic/src/core/worker.c

Line 174 in 101f6b9

CxPlatEventWaitForever(Worker->Done);

RegistrationClose doesn't return by here
Edit: QuicWorkerLoop is not called for some reason

Likely means the worker thread isn't actually woken to clean up.