Add vmProviderReady field to NodeInfo proto - #427
Merged
Nicolas Ontiveros (niontive) merged 1 commit intoApr 15, 2026
Merged
Conversation
Dhaval Popat (dhavalpopat)
previously approved these changes
Apr 14, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add google.protobuf.BoolValue vmProviderReady = 10 to the NodeInfo message in moc_common_nodeinfo.proto. This allows wssdagent to report whether its VM provider has completed bootstrap, so wssdcloudagent can skip nodes that are not yet ready for VM placement. Uses BoolValue (not bare bool) so that old agents that don't set the field return nil, which is distinguishable from an explicit false (not ready). Bug 5: Node selection ignores readiness Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Nicolas Ontiveros (niontive)
force-pushed
the
users/niontive/fix-node-readiness-placement
branch
from
April 15, 2026 02:31
0620df3 to
870f771
Compare
John Carden (jocardeMSFT)
approved these changes
Apr 15, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Dhaval Popat (dhavalpopat)
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
google.protobuf.BoolValue vmProviderReady = 10to theNodeInfomessage inmoc_common_nodeinfo.proto.Problem
When wssdagent restarts, its VM provider runs a sequential bootstrap (~4.5 hours for ~800 VMs). During this window, the health endpoint reports the node as healthy because it has no readiness awareness. wssdcloudagent's
SelectAnyNode()routes new VMs to the bootstrapping node, which rejects them withProviderNotReady.Change
google.protobuf.BoolValue vmProviderReady = 10toNodeInfo(field 10)BoolValue(not barebool) for backward compatibility:nil= old agent (field not set) → treat as readyBoolValue{false}= new agent, still bootstrapping → skip nodeBoolValue{true}= new agent, ready → allow placement.pb.gobindings viamake generatePart of
Coordinated fix across 3 repos:
Bug 5: Node selection ignores VM provider readiness