fix: add nil guards to prevent panic in tags package - #416
Closed
Madhan Raj Mookkandy (madhanrm) wants to merge 1 commit into
Closed
fix: add nil guards to prevent panic in tags package#416Madhan Raj Mookkandy (madhanrm) wants to merge 1 commit into
Madhan Raj Mookkandy (madhanrm) wants to merge 1 commit into
Conversation
AddTag, AddTagValue, and DeleteTag all dereference the tags pointer without checking for nil. When callers pass nil *common.Tags (e.g., wssdcloudagent/virtualmachineimage/client.go:953 during VM Create), the functions panic with nil pointer dereference. Production telemetry (HostOsPanicLogs, 30-day window) shows 4 panics at tags.go:58 (AddTagValue) across 2 devices. Fix: Add nil guard at the top of AddTag, AddTagValue, and DeleteTag. GetTagValue already handles nil safely via GetTags() proto accessor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
Auto-closing this PR as part of the monthly stale-PR cleanup - it has been open for over 90 days or has had no activity in the last 90 days. This is reversible: reactivate the PR if it is still needed. - automated cleanup on behalf of madhanm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddTag, AddTagValue, and DeleteTag all dereference the tags pointer without checking for nil. When callers pass nil *common.Tags\ (e.g., \wssdcloudagent/virtualmachineimage/client.go:953\ during VM Create), the functions panic with nil pointer dereference.
Telemetry Evidence
Production telemetry from \HostOsPanicLogs\ (30-day window) shows 4 panics at \ ags.go:58\ (AddTagValue) across 2 devices.
Stack trace:
\
tags.AddTagValue (tags.go:58)
← virtualmachineimage.client.go:953
← virtualmachine.client.go:2029
← VirtualMachineAgent_Invoke_Handler (VM Create)
\\
Changes
Testing
Engineering Checklist Status