[Protobuf] VM Reconnect changes - #405
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new gRPC method HasHyperVVm to the VirtualMachineAgent service to check if a Hyper-V VM exists by name. The changes include new protobuf message definitions and their corresponding generated Go code.
- Introduces
VirtualMachineHyperVVmRequestandVirtualMachineHyperVVmResponsemessages - Adds
HasHyperVVmRPC method to VirtualMachineAgent service - Updates dependency
google.golang.org/genproto/googleapis/rpcto a newer version
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rpc/nodeagent/compute/virtualmachine/moc_nodeagent_virtualmachine.proto | Adds new protobuf messages and RPC method for checking Hyper-V VM existence |
| rpc/nodeagent/compute/moc_nodeagent_virtualmachine.pb.go | Auto-generated Go code from protobuf definitions |
| go.mod | Updates genproto/googleapis/rpc dependency version |
| go.sum | Updates checksums for the updated dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Jia Yu (yujiaucr)
approved these changes
Oct 28, 2025
Dhaval Popat (dhavalpopat)
approved these changes
Oct 29, 2025
neerajdixit-msft2
requested review from
YuanZh (YuanMSFT),
Blair Urish (blairurish) and
Jonah Kohn (jonah-kohn)
October 29, 2025 16:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Customers need the ability to move VMs between different or same Azure Local cluster. The detailed PM document is at PM 2 Pager Document
Related PRs
[Cloud agent] VM Reconnect changes by neerajdixit-msft2 · Pull Request #1609 · microsoft/wssdclouda…
[Node agent] VM Reconnect changes by neerajdixit-msft2 · Pull Request #1440 · microsoft/wssdagent
[Node sdk] VM reconnect changes by neerajdixit-msft2 · Pull Request #339 · microsoft/wssd-sdk-for-go
[Cloud SDK] VM reconnect changes by neerajdixit-msft2 · Pull Request #356 · microsoft/moc-sdk-for-go
[moccli] VM Reconnect changes by neerajdixit-msft2 · Pull Request #346 · microsoft/moccli
Pull request 13831808: [Testing] VM reconnect changes - Repos
Summary of changes
These PRs accomplish the following:
Testing
Automated testing via MOC cicd - Run pending
Manual testing