Skip to content

feat: expose HyperVVmId, HostNodeName, HostNodeIpAddress on VirtualMachineProperties - #378

Closed
John Carden (jocardeMSFT) wants to merge 1 commit into
mainfrom
users/jocarde/vm-get-all
Closed

feat: expose HyperVVmId, HostNodeName, HostNodeIpAddress on VirtualMachineProperties#378
John Carden (jocardeMSFT) wants to merge 1 commit into
mainfrom
users/jocarde/vm-get-all

Conversation

@jocardeMSFT

Copy link
Copy Markdown

Summary

Problem Statement

The moc-operator needs HyperVVmId, HostNodeName, and HostNodeIpAddress from the VM Get response to avoid making 3 separate dedicated RPCs per reconcile.

Proposed Solution

  • Add HyperVVmId, HostNodeName, and HostNodeIpAddress fields to VirtualMachineProperties in compute.go
  • Wire proto-to-SDK conversion in virtualmachine.go to populate the new fields from the enriched proto response

Dependencies

Testing Complete

  • make build succeeds
  • make unittest passes
  • Manual testing pending

…lMachineProperties

Add new read-only fields to VirtualMachineProperties and populate them
from the enriched proto VirtualMachine response, so SDK consumers can
read all VM host info from a single Get call.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread go.mod
Comment thread services/compute/compute.go
@jocardeMSFT

Copy link
Copy Markdown
Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jocardeMSFT

Copy link
Copy Markdown
Author

All gates pass with redirects

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants