Skip to content

[AdvancedNetworkPolicy] MOC-SDK Changes for LNET and NIC - #332

Merged
mjethwa-msft merged 10 commits into
mainfrom
user/mjethwa-msft/sdn-optionality
Sep 5, 2025
Merged

[AdvancedNetworkPolicy] MOC-SDK Changes for LNET and NIC#332
mjethwa-msft merged 10 commits into
mainfrom
user/mjethwa-msft/sdn-optionality

Conversation

@mjethwa-msft

@mjethwa-msft mjethwa-msft commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces support for AdvancedNetworkPolicy in the LogicalNetwork and NetworkInterface, enabling the representation and conversion of advanced network policy types between SDK and cloud agent formats. Key changes include the addition of new types and methods for advanced network policies, and integration of these policies into logical networks and network interfaces.

Advanced Network Policy Implementation:

  • New Types and Methods:
    • Added NetworkPolicyType and AdvancedNetworkPolicy types to represent advanced network policies in services/network/network.go. [1] [2]
    • Implemented helper functions (GetWssdAdvancedNetworkPolicies, GetNetworkAdvancedNetworkPolicies, getWssdPolicyType, getNetworkPolicyType) in services/network/common.go for converting policies between SDK and cloud agent representations.

Logical Network Enhancements:

  • Logical Network Updates:
    • Integrated AdvancedNetworkPolicies into the logical network creation and retrieval processes in services/network/logicalnetwork/logicalnetwork.go. [1] [2] [3]

Network Interface Enhancements:

  • Network Interface Updates:
    • Added support for AdvancedNetworkPolicies in network interface creation and retrieval in services/network/networkinterface/networkinterface.go. [1] [2] [3]

Dependency Updates:

TODO:

  • go.mod:
    • Update github.com/microsoft/moc to a newer version once merged (v0.34.1-0.20250728164450-563bb240a68a).

Feature design doc for more details:

Related PRs:

@mjethwa-msft

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mjethwa-msft

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mjethwa-msft

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@nijosmsft Nithin Jose (nijosmsft) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mjethwa-msft

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mjethwa-msft
mjethwa-msft force-pushed the user/mjethwa-msft/sdn-optionality branch from 1b04023 to a1b9295 Compare September 2, 2025 19:39
@mjethwa-msft

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mjethwa-msft
mjethwa-msft force-pushed the user/mjethwa-msft/sdn-optionality branch from a1b9295 to 1c28ed6 Compare September 4, 2025 17:14
@mjethwa-msft

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

adfema
adfema previously approved these changes Sep 4, 2025
@mjethwa-msft

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@nijosmsft Nithin Jose (nijosmsft) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjethwa-msft
mjethwa-msft merged commit 54eb6b8 into main Sep 5, 2025
7 checks passed
@mjethwa-msft
mjethwa-msft deleted the user/mjethwa-msft/sdn-optionality branch September 9, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants