Feature support i18n for cn-ZH and en-US #322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dkzjq thank you for the contribution. Could you change the default language to English for both the frontend and backend? Could you also ensure that all comments in any part of the code are written in English? Once that is done, could you create a new PR with only the translational changes? The current PR proposes changes that are not described in the description and that go beyond purely cosmetic translation, which makes it harder for the team to review. |
|
Already push commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Feature for support i18n for cn-ZH and en-US language
Description:
Support i18n-react for frontend and support different language for backend websocket message
Problem:
--
Solution:
Support i18n-react for frontend and support different language for backend websocket message
Changes:
Support i18n-react for frontend and support different language for backend websocket message
Impact:
--
Notes:
Please review the implementation and provide feedback. Let me know if additional tests or adjustments are required.