Skip to content

[Feat] Introduce linting in frontend project #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 29 commits into from
Closed

[Feat] Introduce linting in frontend project #187

wants to merge 29 commits into from

Conversation

stefanoamorelli
Copy link
Contributor

  • chore: add eslint configuration
  • chore: add lintrc file
  • refactor: fix typecheck issues
  • fix(lint): linting errors
  • ci: add frontend lint check

Solves: #133

We introduce ESlint for the frontend/, fix the existing issues, and add a Github workflow to run the linting and prevent merging of code that does not pass the linting.

@stefanoamorelli
Copy link
Contributor Author

@microsoft-github-policy-service agree

@stefanoamorelli
Copy link
Contributor Author

@matheusmaldaner as promised, here you are! :)

Would appreciate your through review as the PR is medium-sized due to fixing the existing linting error.

@matheusmaldaner
Copy link
Contributor

Hi @stefanoamorelli, thank you so much for all the changes! Could you review my minor commit? Your linting implementation highlighted some other cases that were failing with the yarn typecheck command, which I have addressed.

Do you know why the Frontend Checks (frontend-lint) are failing in the GitHub CI workflow? I ran the code on my end and there are no errors.

matheusmaldaner
matheusmaldaner approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@matheusmaldaner matheusmaldaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good linting changes, do not seem to change anything that could break the code. All tests (poe check) are still passing.

stefanoamorelli
stefanoamorelli commented Jun 14, 2025
View reviewed changes
stefanoamorelli
stefanoamorelli commented Jun 14, 2025
View reviewed changes
@stefanoamorelli
Copy link
Contributor Author

@matheusmaldaner good stuff! I've reviewed your commit, LGTM left just a couple of comments to confirm.

Also, I've pushed a commit to allow warnings to allow the CI/CD to pass with warnings (given that we don't introduce more warnings).

@matheusmaldaner
Copy link
Contributor

Requested a review from @husseinmozannar on this so we can merge it before too many changes are made to the system and also so that he can maybe shed light into why the first check is still failing

@stefanoamorelli
Copy link
Contributor Author

Requested a review from @husseinmozannar on this so we can merge it before too many changes are made to the system and also so that he can maybe shed light into why the first check is still failing

Sounds good 👌

@stefanoamorelli
Copy link
Contributor Author

@matheusmaldaner I've rebased the branch and pushed another commit to try fix the failing linting on CI.

Is there anything I can do to help unblock this? Happy to help!

@matheusmaldaner
Copy link
Contributor

Hi @stefanoamorelli the first check still fails and I am unsure why :/

Could you look into this whenever you got the time or let me know if there is anything I can do on my end to help us solve this issue? Thank you a lot for the contributions and the help with this

vrashankshetty and others added 16 commits June 29, 2025 23:37
@vrashankshetty @husseinmozannar @stefanoamorelli
Add agent icons to steps in frontend (microsoft#110) (microsoft#193)
1933911 
Co-authored-by: Hussein Mozannar <[email protected]>
Co-authored-by: Hussein Mozannar <[email protected]>
@tylerpayne @husseinmozannar @stefanoamorelli
Bugfix: StdioServerForm Command Input Stripping Spaces (microsoft#201)
8fcced3 
Co-authored-by: Tyler Payne <[email protected]>
Co-authored-by: Hussein Mozannar <[email protected]>
@husseinmozannar @stefanoamorelli
fix lock file (microsoft#202)
ac104fe
@husseinmozannar @stefanoamorelli
fix server url for remote connections (microsoft#203)
3edf042
@husseinmozannar @stefanoamorelli
bump version (microsoft#204)
b5726c0
@tylerpayne @stefanoamorelli
Remove py3.10 incompatible import (microsoft#208)
62a17df 
Co-authored-by: Tyler Payne <[email protected]>
@tylerpayne @husseinmozannar @stefanoamorelli
Fix model_info bug blocking Ollama model configs (microsoft#207)
7e38915 
Co-authored-by: Tyler Payne <[email protected]>
Co-authored-by: Hussein Mozannar <[email protected]>
@husseinmozannar @Copilot @stefanoamorelli
Make Docker optional (microsoft#209)
15d8244 
Co-authored-by: Copilot <[email protected]>
Co-authored-by: matheusmaldaner <[email protected]>
@husseinmozannar @stefanoamorelli
version upgrade 0.0.6 (microsoft#211)
08f0d29
@husseinmozannar @stefanoamorelli
Fix playwright fill id (microsoft#212)
c4dfd8f 
Fix playwright fill id to use coordinates rather than element typing.

Fix already covered by playwright tests

Better simulates how real users would interact with the website by sending actual keyboard events to the browser
@husseinmozannar @stefanoamorelli
Update README.md for docker running instructions (microsoft#224)
5e6429e
@vballoli @husseinmozannar @stefanoamorelli
Add QA support to Evals (microsoft#210)
c6ecad9 
Co-authored-by: Hussein Mozannar <[email protected]>
Co-authored-by: Hussein Mozannar <[email protected]>
@stefanoamorelli
chore(lint): increase max warnings threshold
302205f
@stefanoamorelli
chore(ci): relax lint warnings
d66ad0f
@stefanoamorelli
refactor(components): remove unused props and imports
a608453
@stefanoamorelli
feat(config): add YAML support for model client configuration
6b5c9c6
@stefanoamorelli stefanoamorelli marked this pull request as draft June 29, 2025 20:42
@stefanoamorelli
Copy link
Contributor Author

stefanoamorelli commented Jun 29, 2025 •
edited
Loading

@matheusmaldaner thank you! The branch was outdated and I must have corrupted the git history when resolving all the conflicts (there were quite a few as the linting fixes touched a lot of files).

I've created a new PR with the most up to date branch and the linting should pass there (it was failing because new errors appeared when rebasing): #234

I'm closing this one and we can continue the conversation in the new PR 🙏

(I've also split the changes in atomic commits as an effort to make review easier for you!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matheusmaldaner matheusmaldaner Awaiting requested review from matheusmaldaner

@husseinmozannar husseinmozannar Awaiting requested review from husseinmozannar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stefanoamorelli @matheusmaldaner @suifengpiaosan @husseinmozannar @tylerpayne @vrashankshetty @vballoli