Skip to content

Fix broken "Implementations" link in navigation #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Fix broken "Implementations" link in navigation #2193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/topnav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ <h1>LSP / LSIF</h1>
<a class="nav-link" href='{{ "/overviews/lsp/overview" | prepend: site.baseurl }}'>Overview</a>
</li>
<li {% if page.sectionid=='implementors' %} class="nav-item active" {% else %} class="nav-item" {% endif %}>
<a class="nav-link" href="{{ implementors.first.url | prepend: site.baseurl }}">Implementations</a>
<a class="nav-link" href='{{ "/overviews/implementations" | prepend: site.baseurl }}'>Implementations</a>
</li>
<li {% if page.sectionid=='specification' %} class="nav-item active" {% else %} class="nav-item" {% endif %}>
<a class="nav-link" href='{{ "/specifications/specification-current" | prepend: site.baseurl }}'>Specification</a>
Expand Down
6 changes: 6 additions & 0 deletions _overviews/implementations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
title: Implementations
index: 1
---

This page provides an overview of the various implementations of the Language Server Protocol.
14 changes: 14 additions & 0 deletions tests/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
window.onload = function() {
var iframe = document.getElementById('site-frame');
var iframeWindow = iframe.contentWindow;

iframe.onload = function() {
var implementationsLink = iframeWindow.document.querySelector('a[href="/language-server-protocol/overviews/implementations"]');

if (implementationsLink) {
console.log('Test passed: Implementations link found.');
} else {
console.error('Test failed: Implementations link not found.');
}
};
};
10 changes: 10 additions & 0 deletions tests/test_runner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!DOCTYPE html>
<html>
<head>
<title>Test Runner</title>
</head>
<body>
<iframe id="site-frame" src="../index.html" width="800" height="600"></iframe>
<script src="test.js"></script>
</body>
</html>