Use torch::tensor instead of ks::tensor in entry points#931
Conversation
awf
left a comment
There was a problem hiding this comment.
Fab, thanks.
We might one day want to passs numpy arrays to KS, I don't know if that has any implications for the code we keep.
| declare_tensor_1<ks::Float>(m, "Tensor_1_Float"); | ||
| declare_tensor_2<ks::Float>(m, "Tensor_2_Float"); | ||
| declare_tensor_2<int>(m, "Tensor_2_Integer"); |
45c7144 to
c2d5268
Compare
a90a4af to
c73aa2c
Compare
8f45fac to
9d9571b
Compare
e6a2ef1 to
b92b82f
Compare
6c28b5f to
387dda2
Compare
b92b82f to
4da90f2
Compare
05d499c to
d114505
Compare
d114505 to
2b74bb5
Compare
2b74bb5 to
4184b70
Compare
|
An additional complication: we have some tests ( At the moment this is all done by adding a new boolean parameter |
awf
left a comment
There was a problem hiding this comment.
Happy with the bool, we can generalize later if neccesary
AB#19887
Draft PR: the current version breaks some of the python tests.fixedMove the conversions between torch types and ks types into C++ code (generated by
python/ksc/cgen.py). Example code generated for relu3: