Skip to content

ConsoleSize --> uint #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lowenna merged 1 commit into from
Sep 16, 2016
+1 −1
Merged

ConsoleSize --> uint #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type ProcessConfig struct {
CreateStdInPipe bool
CreateStdOutPipe bool
CreateStdErrPipe bool
ConsoleSize [2]int
ConsoleSize [2]uint
Copy link
Contributor

@darstahl darstahl Sep 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is actually used in the platform. We might be ok to just remove it (We already set console size with the ResizeConsole method).

Copy link
Contributor

@darstahl darstahl Sep 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test without it against TP5

Copy link
Contributor Author

@lowenna lowenna Sep 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, re TP5: moby/moby#26613 😄. We do use it though to set the initial console size. Following updates are sent through resize.

Copy link
Contributor

@darstahl darstahl Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following offline discussion, LGTM

}

type Layer struct {
Expand Down