fix(apollo-forest-run): fix cache.modify within optimistic transaction #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
cache.modifyissued within optimistic transaction doesn't work properly if modified node does not exist in the optimistic layer of the current optimistic transaction.Apollo InMemoryCache doesn't have this problem because it can store individual fields in the layers. So
cache.modifyreads from layers below, but stores modified fields (only) in the same layer.TODO: ForestRun doesn't store individual fields, so in order to properly mimic Apollo behavior we need to either copy chunks from lower layers, or create "fake" chunk in the optimistic layer with only modified fields.