Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Prompt Node Options Structure #967

Merged
merged 4 commits into from
Dec 25, 2024
Merged

Refactor Prompt Node Options Structure #967

merged 4 commits into from
Dec 25, 2024

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Dec 24, 2024

The refactor moves options into explicit properties for PromptDefNode and PromptDefDataNode, enhancing clarity and structure in the codebase. Additionally, it updates related functions to accommodate this change.


  • Renamed script to ephemeral.genai.mjs from summarize-cached.genai.mjs. 🔄
  • Added new option model: "small" to the script. This could affect how the model processes the data it receives. 👨‍💻🔍

AI-generated content by pr-describe may be incorrect

Copy link

Investigator report

, fba2603

AI-generated content by gai may be incorrect

Copy link

LGTM 🚀

The changes in promptdom.ts seem to have added options to the interfaces for better flexibility in handling definitions and data nodes. The introduction of the options object parameterizes how the nodes are resolved and rendered, enhancing the modularity and reusability of components. The function implementations that use these interfaces now handle the new options property gracefully by using optional chaining.

The only concern might be potential misuse or complexity if not used carefully, as it opens up more possibilities for users to pass inconsistent options. However, given the clear implementation details, this seems manageable and beneficial for future enhancements.

Overall, the change introduces a clean and functional way to extend node behaviors without introducing breaking changes in existing usages.

AI-generated content by pr-review may be incorrect

@pelikhan
Copy link
Member Author

#927

@pelikhan pelikhan merged commit 7090d29 into main Dec 25, 2024
13 checks passed
@pelikhan pelikhan deleted the ephemeralfix branch December 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant