-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to eslint v9 #33527
Open
mainframev
wants to merge
22
commits into
microsoft:master
Choose a base branch
from
mainframev:eslint-v9-with-flag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: migrate to eslint v9 #33527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricteam
reviewed
Dec 30, 2024
🕵 FluentUIV0 No visual regressions between this PR and main |
c6b91dd
to
a8bd13f
Compare
📊 Bundle size report✅ No changes found |
cc6f3e3
to
c71d536
Compare
Pull request demo site: URL |
889a93b
to
e1a4584
Compare
eb15a30
to
df1d6c8
Compare
fabricteam
reviewed
Feb 12, 2025
987ce1b
to
0d3f32f
Compare
f68ba1e
to
c507fc7
Compare
c507fc7
to
bb4d3fa
Compare
…act-hooks chore(fabric): suppress deprecation errors chore: suppress deprecation errors chore: remove odd addition
…our of just-scripts option
584e90d
to
eb590cf
Compare
eb590cf
to
18cae15
Compare
18cae15
to
06adaef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to ESLint v9 but sticking with the legacy config format for now. Jumping straight to the new flat format is too much all at once. The plan is to first update ESLint with legacy flag and all related plugins to make sure everything works. After that, will start moving our .eslintrc files over to eslint.config.js and switch to the new flat format
In follow-up internal
eslint-plugin
will be moved to flat config,eslint-plugin-react-components
will be compatible with both 8 and 9 versions.Previous Behavior
New Behavior
Related Issue(s)