Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to eslint v9 #33527

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

mainframev
Copy link
Contributor

@mainframev mainframev commented Dec 30, 2024

Upgrading to ESLint v9 but sticking with the legacy config format for now. Jumping straight to the new flat format is too much all at once. The plan is to first update ESLint with legacy flag and all related plugins to make sure everything works. After that, will start moving our .eslintrc files over to eslint.config.js and switch to the new flat format

In follow-up internal eslint-plugin will be moved to flat config, eslint-plugin-react-components will be compatible with both 8 and 9 versions.

Previous Behavior

New Behavior

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 30, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@mainframev mainframev force-pushed the eslint-v9-with-flag branch 3 times, most recently from c6b91dd to a8bd13f Compare December 31, 2024 17:05
Copy link

github-actions bot commented Dec 31, 2024

📊 Bundle size report

✅ No changes found

@mainframev mainframev force-pushed the eslint-v9-with-flag branch 2 times, most recently from cc6f3e3 to c71d536 Compare January 2, 2025 21:05
Copy link

github-actions bot commented Jan 2, 2025

Pull request demo site: URL

@mainframev mainframev force-pushed the eslint-v9-with-flag branch 2 times, most recently from 889a93b to e1a4584 Compare January 9, 2025 15:50
@mainframev mainframev force-pushed the eslint-v9-with-flag branch 3 times, most recently from eb15a30 to df1d6c8 Compare February 12, 2025 10:16
@mainframev mainframev force-pushed the eslint-v9-with-flag branch 3 times, most recently from 987ce1b to 0d3f32f Compare February 13, 2025 18:14
@mainframev mainframev marked this pull request as ready for review February 13, 2025 21:45
@mainframev mainframev force-pushed the eslint-v9-with-flag branch from f68ba1e to c507fc7 Compare March 31, 2025 12:40
@mainframev mainframev dismissed stale reviews from AtishayMsft and Hotell via c507fc7 April 1, 2025 06:42
@mainframev mainframev force-pushed the eslint-v9-with-flag branch from c507fc7 to bb4d3fa Compare April 1, 2025 16:48
@mainframev mainframev force-pushed the eslint-v9-with-flag branch 2 times, most recently from 584e90d to eb590cf Compare April 2, 2025 17:18
@mainframev mainframev force-pushed the eslint-v9-with-flag branch from eb590cf to 18cae15 Compare April 2, 2025 17:35
@mainframev mainframev force-pushed the eslint-v9-with-flag branch from 18cae15 to 06adaef Compare April 2, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants