Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCommentsGenerator] [v5] Fix initial build after first clone #3084

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

oneolddev
Copy link
Contributor

@oneolddev oneolddev commented Dec 22, 2024

Pull Request

📖 Description

Found an issue when attempting to build branch dev-v5 after cloning it.

image

🎫 Issues

The Microsoft.FluentUI.AspNetCore.Components.xml file does not exist when this if first run. Thus there are no members to document.

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@oneolddev oneolddev changed the title [CodeCommentsGenerator] [v5] Fix initial build after first clone and checkout [CodeCommentsGenerator] [v5] Fix initial build after first clone Dec 22, 2024
@oneolddev oneolddev marked this pull request as ready for review December 22, 2024 22:24
@oneolddev oneolddev marked this pull request as draft December 22, 2024 22:29
@oneolddev oneolddev marked this pull request as ready for review December 22, 2024 22:44
@vnbaaij vnbaaij merged commit 4ce1a55 into microsoft:dev-v5 Dec 23, 2024
3 checks passed
@oneolddev oneolddev deleted the fix-source-gen branch December 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants