i18n: Add Arabic translations for various UI elements in edit.toml #634
Conversation
|
@microsoft-github-policy-service agree |
| # Shown when the clipboard size exceeds the limit for OSC 52 | ||
| [LargeClipboardWarningLine2] | ||
| en = "You copied {size} which may take a long time to share." | ||
| ar = "لقد قمت بنسخ {size} مما قد يستغرق وقتًا طويلاً للمشاركة." |
There was a problem hiding this comment.
sentence is backward here? probably because you mixed RTL and LTR together? It should be like this:
لقد قمت بنسخ {size} مما قد يستغرق وقتًا طويلاً للمشاركة.
But frankly, I have seen this happening even when adding Arabic (or any RTL language) in XML files. It seems they are not designed for RTL support.
Also, most of the punctuations like periods, colons, ..etc. should be on the left side of the sentence, not the right side where the sentence begins.
i18n/edit.toml
Outdated
| __default__ = [ | ||
| "en", | ||
| # -------- | ||
| "ar", |
There was a problem hiding this comment.
We won't add new languages to the default selection shipped with Windows at this time, so this needs to be reverted.
There was a problem hiding this comment.
Thank you for the review!
I’ve reverted the language addition and removed the redundant lines as suggested.
i18n/edit.toml
Outdated
| # The keyboard key | ||
| [Ctrl] | ||
| en = "Ctrl" | ||
| ar = "Ctrl" |
There was a problem hiding this comment.
Unspecified elements fall back to English, so this line is redundant. Same for the lines below.
3 participants
This pull request adds Arabic translations for many common UI strings in the
i18n/edit.tomlfile, expanding the application's language support. The changes include adding Arabic as a supported language and providing Arabic translations for menu items, dialog buttons, warnings, and search labels.