Enable ASPNET Core Endpoint routing #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunmk-ms
changed the title
wsugarman
requested changes
Jan 17, 2024
src/Microsoft.Health.Dicom.Api/Registration/DicomServerApplicationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Api/Registration/DicomServerApplicationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
wsugarman
reviewed
Jan 18, 2024
wsugarman
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the files to use Aspnetcore Endpoint Routing instead of MVC. Endpoint routing is needed to add HttpLoggingMiddleware to get request logs in Otel migration work.
Registration is updated following the migration guide
Fetching routeContext for the bundle was using mvc router which is not provided in the endpoint routing framework. So adding the method to build routeContext for the bundle requests.
Related issues
Addresses issue #113900.
Testing
Existing tests continue to pass.