fix(engine): inherit background mode in subworkflows - #525
Merged
Jason Robert (jrob5756) merged 1 commit intoSep 11, 2026
Merged
Conversation
Artur Leao (arturleao)
marked this pull request as ready for review
September 11, 2026 09:14
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
=======================================
Coverage ? 92.00%
=======================================
Files ? 165
Lines ? 27335
Branches ? 0
=======================================
Hits ? 25149
Misses ? 2186
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jason Robert (jrob5756)
approved these changes
Sep 11, 2026
Jason Robert (jrob5756)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
human_gatesteps from racing a CLI stdin prompt under--web-bg.Why
Only the CLI builds
RunContext. Child engines previously sawbg_mode=False, so a nested gate could callPrompt.ask, raiseEOFError, and fail a background workflow even while a web dashboard was available.Testing
tests/test_engine/test_subworkflow.py(42 passed)