Skip to content

Fix toolbar download bug: use correct file extension, MIME type, dynamic UI text, and address CodeQL security alert #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dan Marshall (danmarshall) merged 18 commits into from
Sep 10, 2025
Merged

Fix toolbar download bug: use correct file extension, MIME type, dynamic UI text, and address CodeQL security alert #72

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b937369
Initial plan
Copilot Sep 5, 2025
e5d2159
Initial analysis: Plan to fix toolbar download bug
Copilot Sep 5, 2025
66b8952
Fix toolbar download bug - use correct extension and MIME type based …
Copilot Sep 5, 2025
e5b4c4f
Update download UI text to be more explicit about json/markdown content
Copilot Sep 5, 2025
d4a8f4b
Make download text dynamic based on mode (json/markdown)
Copilot Sep 5, 2025
934af2e
Potential fix for code scanning alert no. 43: Unsafe HTML constructed…
danmarshall Sep 5, 2025
90474ab
Add displayMode variable to fix CodeQL alert for safe HTML construction
Copilot Sep 5, 2025
9c939db
Undo package-lock.json changes - revert version back to 1.0.0
Copilot Sep 10, 2025
ede0587
Merge branch 'main' into copilot/fix-ddeaff9e-c035-4a98-b20b-7fd67d80…
danmarshall Sep 10, 2025
cd4cf65
convert toolbar to tsx
danmarshall Sep 10, 2025
29da5fd
Add folderSpan property to Toolbar class and update initialization
danmarshall Sep 10, 2025
6a47c94
Refactor toolbar CSS classes for improved structure and consistency
danmarshall Sep 10, 2025
7aee5f9
Update toolbar CSS link to include version query parameter
danmarshall Sep 10, 2025
72cdf7c
regen
danmarshall Sep 10, 2025
484018f
convert folder to JSX
danmarshall Sep 10, 2025
81e4f47
regen
danmarshall Sep 10, 2025
43ec2bc
Remove unused folderSpan element from ToolbarElement and related refe…
danmarshall Sep 10, 2025
bfc76cc
regen
danmarshall Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions packages/toolbar/src/toolbar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
<div style="margin-bottom: 8px;">Download as:</div>
<ul>
<li>
Source markdown (just the content)<br/>
<button type="button" id="download-md" style="margin-right: 8px;">Source markdown</button>
Source (just the ${this.mode} content)<br/>
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
<button type="button" id="download-md" style="margin-right: 8px;">Source</button>
</li>
<li>
HTML wrapper (content plus a shareable viewer)<br/>
Expand Down Expand Up @@ -127,8 +127,10 @@
const textarea = this.options.textarea;
if (!textarea) return;
const content = textarea.value;
const filename = `${filenameWithoutPathOrExtension(this.filename)}.idoc.md`;
this.triggerDownload(content, filename, 'text/markdown');
const extension = this.mode === 'json' ? '.idoc.json' : '.idoc.md';
const mimeType = this.mode === 'json' ? 'application/json' : 'text/markdown';
const filename = `${filenameWithoutPathOrExtension(this.filename)}${extension}`;
this.triggerDownload(content, filename, mimeType);
});

// Download as HTML wrapper
Expand Down