Skip to content

Support multiple certificate and different number of empty lines for netsh #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yepeekai wants to merge 4 commits into from
Closed

Support multiple certificate and different number of empty lines for netsh #1153

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d45c5f1
Support if a different number of empty lines is provided by the outup…
Apr 26, 2023
dd5e1b9
Error when copy pasting
Apr 26, 2023
509c35c
Correction for certificate comparison.
Jul 10, 2023
4173f75
Refactored Add-SslCert
Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions TaskModules/powershell/TaskModuleIISManageUtility/AppCmdOnTargetMachines.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,12 @@ function Add-SslCert
Write-Verbose "Checking if SslCert binding is already present. Running command : netsh $showCertCmd"

$result = Invoke-VstsTool -Filename "netsh" -Arguments $showCertCmd
$isItSameBinding = $result.Get(4).Contains([string]::Format("{0}:{1}", $hostname, $port))

$result = $result | where {$_.TrimStart().StartsWith("Hostname:port") -and $_.Contains([string]::Format("{0}:{1}", $hostname, $port))}
if($result)
{
$isItSameBinding = $true
}

$addCertCmd = [string]::Format("http add sslcert hostnameport={0}:{1} certhash={2} appid={{{3}}} certstorename=MY", $hostname, $port, $certhash, [System.Guid]::NewGuid().toString())
}
else
Expand All @@ -193,8 +197,12 @@ function Add-SslCert
Write-Verbose "Checking if SslCert binding is already present. Running command : netsh $showCertCmd"

$result = Invoke-VstsTool -Filename "netsh" -Arguments $showCertCmd
$isItSameBinding = $result.Get(4).Contains([string]::Format("{0}:{1}", $ipAddress, $port))

$result = $result | where {$_.TrimStart().StartsWith("IP:port") -and $_.Contains([string]::Format("{0}:{1}", $ipAddress, $port))}
if($result)
{
$isItSameBinding = $true
}

$addCertCmd = [string]::Format("http add sslcert ipport={0}:{1} certhash={2} appid={{{3}}} certstorename=MY", $ipAddress, $port, $certhash, [System.Guid]::NewGuid().toString())
}

Expand Down