-
Notifications
You must be signed in to change notification settings - Fork 909
Adding L0 tests for Legacy NodeHandler logic | Adding 2 Knobs for feature flag & EOL toggle status value #5421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rishabhmalikMS
wants to merge
20
commits into
master
Choose a base branch
from
users/rishabhmalikMS/EOLnodeL0Tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,154
−0
Open
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
df2b8fc
Initial commit | node handler strategies | orchestrator to get select…
rishabhmalikMS 42d4769
Adding collection definition for unning all node handling tests in se…
rishabhmalikMS a8c7794
Adding selectedNode field in UnifiedNodeContext | Removing duplicate …
rishabhmalikMS 32becf6
Adding equivalence and diverging test for legacy and new approach | S…
rishabhmalikMS 2e9ef63
Node Handler integrtion fix for custom node (moved legacy custom node…
rishabhmalikMS 6b5cc04
Merged custom node scnario tests with all other test specs
rishabhmalikMS 244ebe6
Code cleaning
rishabhmalikMS ce9dd01
Test scenarios updates
rishabhmalikMS b2450ba
Minor fixes
rishabhmalikMS b1a6dd7
Adding CustomNodeHandlerData handler
rishabhmalikMS af9b999
minor fixes
rishabhmalikMS a95c2ab
L0 unit tests for node handler with all scenarios for node handlers
rishabhmalikMS 84e3eb1
minor fix
rishabhmalikMS 0948f72
Code cleaning
rishabhmalikMS ac6b0cf
Merge branch 'master' into users/rishabhmalikMS/EOLnodeL0Tests
rishabhmalikMS b42cd15
Updating knob name to be consistent with server side updates.
rishabhmalikMS d3f8dfa
Merge branch 'users/rishabhmalikMS/EOLnodeL0Tests' of https://github.…
rishabhmalikMS 06340eb
refactor: Replace 'unified' terminology with 'strategy' in Node.js ha…
rishabhmalikMS 5a08d24
Removed strategyExpectSuccess, legacyExpectSuccess and ExpectSuccess …
rishabhmalikMS 2c73a58
Merge branch 'master' into users/rishabhmalikMS/EOLnodeL0Tests
rishabhmalikMS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using Xunit; | ||
|
|
||
| namespace Microsoft.VisualStudio.Services.Agent.Tests | ||
| { | ||
| /// <summary> | ||
| /// Single collection for ALL NodeHandler tests (legacy and unified). | ||
| /// This ensures sequential execution to prevent environment variable conflicts. | ||
| /// </summary> | ||
| [CollectionDefinition("Unified NodeHandler Tests")] | ||
| public class UnifiedNodeHandlerTestFixture : ICollectionFixture<UnifiedNodeHandlerTestFixture> | ||
| { | ||
| // This class is never instantiated, it's just a collection marker | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using System.Linq; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.VisualStudio.Services.Agent.Tests | ||
| { | ||
| /// <summary> | ||
| /// Unified test runner for ALL NodeHandler test specifications. | ||
| /// Executes every scenario defined in NodeHandlerTestSpecs.AllScenarios. | ||
| /// </summary> | ||
| [Trait("Level", "L0")] | ||
| [Trait("Category", "NodeHandler")] | ||
| [Collection("Unified NodeHandler Tests")] | ||
| public sealed class NodeHandlerL0AllSpecs : NodeHandlerTestBase | ||
| { | ||
| [Theory] | ||
| [MemberData(nameof(GetAllNodeHandlerScenarios))] | ||
| public void NodeHandler_AllScenarios(TestScenario scenario) | ||
| { | ||
| RunScenarioAndAssert(scenario); | ||
| } | ||
|
|
||
| public static object[][] GetAllNodeHandlerScenarios() | ||
| { | ||
| return NodeHandlerTestSpecs.AllScenarios | ||
| .Select(scenario => new object[] { scenario }) | ||
| .ToArray(); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly confusing, we are not upgrading tasks, rather when flag is enabled we disregard the EOL Node versions a task have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is updated to be more descriptive