OaepSHA1 -> OaepSHA256 #4989
Open
OaepSHA1 -> OaepSHA256 #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlynomsft
reviewed
Sep 11, 2024
src/Agent.Listener/Configuration.Windows/RSAEncryptedFileKeyManager.cs
Outdated
Show resolved
Hide resolved
martin-toman
changed the title
martin-toman
force-pushed
the
users/mtoman/update-from-sha1-to-sha256
branch
from
bc8034d to
aa0a9ac
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
martin-toman
changed the title
DergachevE
previously approved these changes
Oct 17, 2024
martin-toman
force-pushed
the
users/mtoman/update-from-sha1-to-sha256
branch
from
aa0a9ac to
a29c01d
Compare
martin-toman
force-pushed
the
users/mtoman/update-from-sha1-to-sha256
branch
from
a29c01d to
e738e1d
Compare
martin-toman
force-pushed
the
users/mtoman/update-from-sha1-to-sha256
branch
from
a29c01d to
c5b7657
Compare
martin-toman
force-pushed
the
users/mtoman/update-from-sha1-to-sha256
branch
from
c5b7657 to
178bc35
Compare
martin-toman
force-pushed
the
users/mtoman/update-from-sha1-to-sha256
branch
from
178bc35 to
3c20b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been flagged by CodeQL for some time.
The backend side change adding OaepSHA256 has rolled out everywhere, the Agent side now needs to be updated to request it.
I tested the OaepSHA256 code path locally, with Windows and macOS self-hosted Agent.
Notes:
RSA.Create()does not supportKeyContainerName, I had to work around that.