Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pydantic version & fix mypy errors #4811

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

srjoglekar246
Copy link
Contributor

Why are these changes needed?

Fix some recently introduced mypy errors & also bump pydantic version so that warnings related to model_ fields go away without code changes.

Checks

  • poe test seems to pass locally.
  • pydantic warnings go away after version bump.

@srjoglekar246
Copy link
Contributor Author

@jackgerrits @ekzhu Trying to fix some pydantic & mypy issues here.

I updated uv.lock as the error suggested, but could you double-check that the diff is okay at a high level?

@ekzhu ekzhu requested a review from jackgerrits December 26, 2024 01:13
@srjoglekar246 srjoglekar246 force-pushed the fixpyissues branch 4 times, most recently from c88f589 to d29cca5 Compare December 26, 2024 21:49
@srjoglekar246
Copy link
Contributor Author

@jackgerrits / @ekzhu Could you double-check if uv sync --locked --all-extras is actually causing issues as mentioned in the CI errors above? Weirdly on my local setup I don't see any issues, and theres no diff I see when I do uv lock. Am I missing something?

@ekzhu
Copy link
Collaborator

ekzhu commented Dec 26, 2024

Could you revert your changes to the lock file to the main branch version, and then, you generate a new one by calling uv sync --all-extras, followed by uv lock to generate a new lock file.

@jackgerrits jackgerrits merged commit d1dff31 into microsoft:main Dec 27, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants