Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate deactivate agents #4800

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peterychang
Copy link
Collaborator

Why are these changes needed?

Create startup/shutdown functions

Related issue number

#4705

Checks

@peterychang
Copy link
Collaborator Author

Getting this up for review. I'll see if any other agents need something done and add documentation for this after the holidays

@jackgerrits
Copy link
Member

Let's keep it to deactivation initially since there is currently no clear use case for activation but there is for deactivation

@jackgerrits
Copy link
Member

Also matter of preference, but I would prefer close

@@ -532,6 +542,13 @@ async def stop(self) -> None:
"""Stop the runtime message processing loop."""
if self._run_context is None:
raise RuntimeError("Runtime is not started")

# deactivate all the agents that have been activated
for agent_id in self._activated_agents:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering we just want shutdown, would be easier to just iterate _instantiated_agents here instead

@husseinmozannar
Copy link
Contributor

reminder to also update autogen studio code where close is called or create an issue so that victor updates it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants