Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update LMStudio API Endpoint and added model name support #4732

Merged
merged 10 commits into from
Dec 27, 2024

Conversation

kimmywork
Copy link
Contributor

@kimmywork kimmywork commented Dec 17, 2024

Why are these changes needed?

LMStudio API requires a version (v1) and model name to invoke.

Related issue number

N/A

Checks

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

dotnet/src/AutoGen/LMStudioConfig.cs Show resolved Hide resolved
dotnet/src/AutoGen/LMStudioConfig.cs Show resolved Hide resolved
@kimmywork
Copy link
Contributor Author

@microsoft-github-policy-service agree

@kimmywork
Copy link
Contributor Author

@LittleLittleCloud
I am trying to run full dotnet test locally but failed with several cases in AutoGen.DotnetInteractive.Tests.
All caused by following exception:

System.ArgumentException : System.ArgumentException: KernelSpec python3 not found

Are there any pre-configuration steps I missed to run the test?

@LittleLittleCloud
Copy link
Collaborator

@kimmywork The error indicates that jupyter kernel is missing in your python env. You would need to configure jupyter kernel

python -m pip install --upgrade pip
python -m pip install jupyter
python -m pip install ipykernel

After that , invoking python -m jupyter kernelspec list to make sure python3 is present there

@kimmywork
Copy link
Contributor Author

@kimmywork The error indicates that jupyter kernel is missing in your python env. You would need to configure jupyter kernel

python -m pip install --upgrade pip
python -m pip install jupyter
python -m pip install ipykernel

After that , invoking python -m jupyter kernelspec list to make sure python3 is present there

Cool, now all tests passed on my local.

@kimmywork
Copy link
Contributor Author

@LittleLittleCloud this pr is still pending review, please take a look :)

@LittleLittleCloud
Copy link
Collaborator

@kimmywork LGTM, thanks for the PR

@LittleLittleCloud LittleLittleCloud merged commit 90a44b5 into microsoft:main Dec 27, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants