Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve string delimiter in type printing. #60729

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Preserve string delimiter in type printing. #60729

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2906dea
Preserve string delimiter in type printing.
dragomirtitian Dec 10, 2024
275f6b9
Only preserve string delimiters if we print for declaration files.
dragomirtitian Dec 16, 2024
638ceea
Preserve original quotes in all except errors.
dragomirtitian Dec 18, 2024
b8d575a
Preserve symbol name string delimiters
dragomirtitian Dec 18, 2024
1f2c52c
Improve preservation of strings in symbol printing.
dragomirtitian Dec 19, 2024
b983d7b
Improve symbol printing.
dragomirtitian Jan 9, 2025
78f7c22
Improve respect of string delimiter preferences.
dragomirtitian Jan 13, 2025
569b7ce
Revereted to using [] for missing names.
dragomirtitian Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revereted to using [] for missing names.
@dragomirtitian
dragomirtitian committed Jan 13, 2025
commit 569b7ce747f24f2bbe24675140e81a8271c64bb1
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Original file line number Diff line number Diff line change
@@ -8554,7 +8554,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
moduleName.symbol = symbol;
return moduleName;
}
if ((symbolNameSource && isIdentifier(symbolNameSource)) || canUsePropertyAccess(symbolName, languageVersion)) {
if ((symbolNameSource && isIdentifier(symbolNameSource) && getFullWidth(symbolNameSource) !== 0) || canUsePropertyAccess(symbolName, languageVersion)) {
const identifier = setEmitFlags(factory.createIdentifier(symbolName), EmitFlags.NoAsciiEscaping);
if (typeParameterNodes) setIdentifierTypeArguments(identifier, factory.createNodeArray<TypeNode | TypeParameterDeclaration>(typeParameterNodes));
identifier.symbol = symbol;
2 changes: 1 addition & 1 deletion src/harness/typeWriter.ts
View file
Original file line number Diff line number Diff line change
@@ -304,7 +304,7 @@ export class TypeWriterWalker {
if (!symbol) {
return;
}
let symbolString = "Symbol(" + this.checker.symbolToString(symbol, node.parent, /*meaning*/ undefined, ts.SymbolFormatFlags.AllowAnyNodeKind);
let symbolString = "Symbol(" + this.checker.symbolToString(symbol, node.parent);
if (symbol.declarations) {
let count = 0;
for (const declaration of symbol.declarations) {
2 changes: 1 addition & 1 deletion tests/baselines/reference/MemberFunctionDeclaration4_es6.symbols
View file
Original file line number Diff line number Diff line change
@@ -5,5 +5,5 @@ class C {
>C : Symbol(C, Decl(MemberFunctionDeclaration4_es6.ts, 0, 0))

*() { }
> : Symbol(C.(Missing), Decl(MemberFunctionDeclaration4_es6.ts, 0, 9))
> : Symbol(C[(Missing)], Decl(MemberFunctionDeclaration4_es6.ts, 0, 9))
}
2 changes: 1 addition & 1 deletion tests/baselines/reference/MemberFunctionDeclaration5_es6.symbols
View file
Original file line number Diff line number Diff line change
@@ -6,5 +6,5 @@ class C {

*
}
> : Symbol(C.(Missing), Decl(MemberFunctionDeclaration5_es6.ts, 0, 9))
> : Symbol(C[(Missing)], Decl(MemberFunctionDeclaration5_es6.ts, 0, 9))

2 changes: 1 addition & 1 deletion tests/baselines/reference/classMemberWithMissingIdentifier.symbols
View file
Original file line number Diff line number Diff line change
@@ -5,5 +5,5 @@ class C {
>C : Symbol(C, Decl(classMemberWithMissingIdentifier.ts, 0, 0))

public {};
> : Symbol(C.(Missing), Decl(classMemberWithMissingIdentifier.ts, 0, 9))
> : Symbol(C[(Missing)], Decl(classMemberWithMissingIdentifier.ts, 0, 9))
}
2 changes: 1 addition & 1 deletion tests/baselines/reference/classMemberWithMissingIdentifier2.symbols
View file
Original file line number Diff line number Diff line change
@@ -5,6 +5,6 @@ class C {
>C : Symbol(C, Decl(classMemberWithMissingIdentifier2.ts, 0, 0))

public {[name:string]:VariableDeclaration};
> : Symbol(C.(Missing), Decl(classMemberWithMissingIdentifier2.ts, 0, 9))
> : Symbol(C[(Missing)], Decl(classMemberWithMissingIdentifier2.ts, 0, 9))
>name : Symbol(name, Decl(lib.dom.d.ts, --, --))
}