fix: harden security beyond PR #249 — command injection, deps, path injection - #264
Open
WODE25500 wants to merge 1 commit into
Open
fix: harden security beyond PR #249 — command injection, deps, path injection#264WODE25500 wants to merge 1 commit into
WODE25500 wants to merge 1 commit into
Conversation
…s, path injection
Five additional security hardening changes identified during a full
repository security audit:
1. Replace os.system() with subprocess.run() in Sleep plugin
(plugins/openclaw/slash_sleep.py) to prevent shell command injection
via unsanitized arguments.
2. Raise dependency floors to address known CVEs:
- vllm >= 0.8.4 (was 0.4.0; CVE-2025-32433 in transitive deps)
- datasets >= 3.0 (was 2.18.0; remote code execution via
load_dataset with untrusted configs)
- Declare openai-codex-sdk as an explicit optional dep (codex extra)
to prevent dependency confusion / undeclared-import attacks.
3. Sanitize task_id before use in tempfile.mkdtemp prefix
(skillopt/envs/spreadsheetbench/rollout.py) to prevent directory
creation at attacker-chosen paths via crafted task identifiers.
4. Extend WebUI security tests from 2 to 8, covering --share warning,
auth via CLI args / env vars, default-no-auth, and path traversal
rejection in scan_outputs().
5. Sync requirements.txt commented versions with pyproject.toml floors.
All 1445 existing tests pass; 6 new regression tests added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up security hardening beyond PR #249, identified during a full repository audit.
Changes
Command injection fix — Replace
os.system()withsubprocess.run()in Sleep plugin (plugins/openclaw/slash_sleep.py) to prevent shell injection via unsanitized arguments.Dependency CVE remediation:
vllmfloor raised to>= 0.8.4(was 0.4.0; CVE-2025-32433 in transitive deps)datasetsfloor raised to>= 3.0(was 2.18.0; remote code execution viaload_datasetwith untrusted configs)codexoptional extra foropenai-codex-sdkto prevent undeclared-import / dependency confusion attacksPath injection fix — Sanitize
task_idbefore use intempfile.mkdtempprefix (skillopt/envs/spreadsheetbench/rollout.py) to prevent directory creation at attacker-chosen paths.WebUI security test expansion — Extended from 2 to 8 tests covering
--sharewarning, auth via CLI args / env vars, default-no-auth, and path traversal rejection.requirements.txt sync — Aligned commented versions with
pyproject.tomlfloors.Test plan
tests/test_webui_security.py)