Implement LWG-4399 enable_nonlocking_formatter_optimization for pair and tuple needs remove_cvref_t
#5897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_optimization for pair and tuple
tests/std/tests/P3107R5_enabled_specializations/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Nov 23, 2025
Member
|
Thanks! 😻 I pushed a commit to further extend the test coverage. |
Contributor
Author
|
Yeah, I should have extracted those myself right away. I hope it did not take you too much valuable time. Excited to get my first PR to STL approved 😅 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
🔒 ❌ 🔓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
remove_cv_ref_ttopairandtuplespecialization ofenable_nonlocking_formatter_optimization.Add tests.
Fixes #5861