Implement LWG-4274: The chrono::hh_mm_ss constructor is ill-formed for unsigned durations #5893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for these LWG PRs - I will try to sneak in a few reviews despite needing to prioritize flat_meow. Just wanted to let you know that I'm not ignoring them and I appreciate all the work (it's just arrived at an exceptionally busy time for me). |
Contributor
Author
…mm_ss from unsigned duration.
Author
|
I took examples from both issues and added them as tests. Indeed, both should also be resolved by this PR. |
tests/std/tests/P0355R7_calendars_and_time_zones_formatting/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_formatting/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Nov 24, 2025
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace call to
chrono::absinchrono::hh_mm_ssctor with new private function handlingdurationwith unsignedrep.Add tests.
Fixes #5857
Edit:
Fixes #4144
Fixes #5569