Skip to content

Conversation

AlexGuteniev
Copy link
Contributor

Follow up to #5533

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner June 14, 2025 17:10
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Jun 14, 2025
@StephanTLavavej StephanTLavavej self-assigned this Jun 14, 2025
@StephanTLavavej StephanTLavavej changed the title REAMDE.md: expand benchmarking examples README.md: expand benchmarking examples Jun 14, 2025
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Jun 14, 2025
@StephanTLavavej StephanTLavavej removed their assignment Sep 17, 2025
@StephanTLavavej
Copy link
Member

Thanks, this is very helpful! I pushed some changes:

  • Title case the section name.
  • Recommend CXXFLAGS instead of _CL_. That way, we don't have to talk about building cleanly, and CXXFLAGS is properly displayed in verbose build logs.
  • Link to CMake docs for CXXFLAGS and Windows docs for start to explain the various parameters.
  • Minor grammar/typo fixes (e.g. "P-cores" is the preferred terminology).

@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Sep 17, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Sep 19, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 4816d1d into microsoft:main Sep 22, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Sep 22, 2025
@StephanTLavavej
Copy link
Member

Thanks for helping contributors write more benchmarks! ⏱️ 🧑‍🔬 🧠

@AlexGuteniev AlexGuteniev deleted the patch-1 branch September 22, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants