-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few improvements to suggest. #402
base: main
Are you sure you want to change the base?
Conversation
…n case of OnEvaluateRule action. RuleCompiler; Thee is an issue when a globalParam is declared, it tries to be added to the input of each rule and subrules failed because it is already there. RuleEngine: The PostActions are executed at the end of the exetuon of every rule, not at the end of the workflow.
@ianido please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Hi @ianido , Thanks for raising this PR, both the suggestions are valid but I would like to discuss them, since it will impact existing functionality. For ExecuteRule, we already have an ability to filter the inputs/scopedparams passed to the chained rule, RulesEngine/src/RulesEngine/Actions/EvaluateRuleAction.cs Lines 46 to 49 in 7949a8b
Also ExecuteRule is intended for cross-workflow rule execution, so it can be subjective whether they want to reuse a global variable from old workflow or new one. In this case, I would suggest creating a new Custom action which meets the specific requirements of the consumer. Adding an implicit filtering on same named scoped param can lead to predictably issues in some cases. |
How can I tell which rules has failed. How to get the fail result back? Thank you. |
Hi, I have been working in a practical application and I found few things you may consider.
EvaluateRuleActions : Allows to track the results of a bifusrcation in case of OnEvaluateRule action.
RuleCompiler; Thee is an issue when a globalParam is declared, it tries to be added to the input of each rule and subrules failed because it is already there.
RuleEngine: The PostActions are executed at the end of the exetuon of every rule, not at the end of the workflow.