[PowerAccent] Add ḱ to PowerAccent for Proto-Indo-European #36408
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
|
@microsoft-github-policy-service agree company="Microsoft" |
| { | ||
| return letter switch | ||
| { | ||
| LetterKey.VK_K => new[] { "ḱ" }, |
There was a problem hiding this comment.
Do we need to add more?
I don't know where are others come from, while from this wiki:
https://en.wikipedia.org/wiki/Proto-Indo-European_language#CITEREFFortson2010
Looks like (I don't know how to systematically extract) there is more than just this.
There was a problem hiding this comment.
Based on the commit history of PowerAccent, my understanding is that it's more like an "on-demand" approach rather than “pull in everything”. For example, #33550.
This change targets to the bug fix of #35471 with clear requirements so I'd recommend we control the blast radius here. Please let me know your thoughts :)
Actually, I'm using this PR to walk myself through the contributing process to see if there's any potential issues for our team.
Summary of the Pull Request
Add ḱ and introduce support for the Proto-Indo-European language in the PowerAccent module.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Build and tested the change locally.
Ḱḱare added.PIEin Settings