-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ironclad CLM (Independent Publisher) #3709
base: dev
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @maxhenkentech,
Please address the review comments and remove the intro.md file which is not needed for Independent Publisher connector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @maxhenkentech,
Please resolve review comments.
independent-publisher-connectors/Ironclad CLM/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Ironclad CLM/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Ironclad CLM/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Ironclad CLM/apiProperties.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Ironclad CLM/apiProperties.json
Outdated
Show resolved
Hide resolved
fixed typos
typos fixed
Thank you, @vmanoharas! All done. |
Added support for Workflow Documents as Array as requested by Ironcald
Added support for Workflow Documents as Array as requested by Ironclad
@vmanoharas: Made minor changes to add support for a feature requested by Ironclad |
Hello @maxhenkentech, Thank you! Could you please update the files with proper indentation? please check the below documentation. https://learn.microsoft.com/en-us/connectors/custom-connectors/coding-standards#api-definition |
Hi @vmanoharas - I pushed all json and C# files through a code prettifier. Hope this works for you guys. Let me know if anything else is required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Partner
I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.
[[certify-connector]] |
Thank you @vmanoharas - do you already have the static callback URL for the connector? Ironclad and I are preparing documentation and would like to include it asap. Thank you 🙏 |
No @maxhenkentech, please include it during this week as it is already approved, our team can take it forward for certification during this week or next week. |
Hi @vmanoharas - we don't really mind what it is. We had understood that MS will assign the static one as indicatd in the apiProperties. Currently we have this:
which is fine We appreciate your support! 🙇🏼 |
Hello @maxhenkentech, Please refer this link - https://learn.microsoft.com/en-us/connectors/custom-connectors/#21-oauth-20 |
Hi @vmanoharas - this is all fine, we just didn't know if anything else is required on the MS side to ensure the GlobalPerConnector callback url is created/can accept callbacks (https://global.consent.azure-apim.net/redirect/ironcladclm). We assume this happens automatically 👍🏻 Thanks! |
Hi @vmanoharas - hope you had a good start into 2025! We are in week 5 now, so wanted to ask when we can expect the connector to become live? We also cannot yet see the pull in the dev repo, so wanted to ask from when we can make some tweaks to the custom connector? We had some feedback with some minor improvements we wanted to pull. Thank you |
Hello @maxhenkentech, Apologies for the delay, and thank you for following up! The deployment was frozen due to the continuous holidays but was lifted this week. We have now started certifying your connector and will provide an update once it has been deployed to all regions. Thank you for your patience and understanding! |
Hi @vmanoharas - Any update on this? Thank you! |
Hi @vmanoharas - could you let us know when we can expect the connector to be certified? Thank you! |
Hello @maxhenkentech, Unfortunately, due to the holiday season, there was a deployment freeze from November 20, 2024, to January 6, 2025, followed by another freeze from January 24 to January 31, 2025, due to Lunar New Year. We are working hard to complete the queue which are lined up in the deployment freeze. This would be deployed to all regions in next 3 to 4 week. |
Hi @vmanoharas - any updates on timelines? Our customers are desperately waiting on the deployment. Thank you! |
Hi @maxhenkentech, Unfortunately, we are currently facing an issue with the oAuth IP connectors. Our team is actively working to resolve this issue. In the meantime, if you could switch the connector to API key and basic authentication, it would help expedite the deployment process. If this is not feasible, we will proceed with the deployment once the issue is resolved. We appreciate your patience and understanding during this time. |
@vmanoharas Can you provide more details for what is the issue with OAuth connector deployment? Is it because they have multiple OAuth configurations? Will this issue affect other connectors on the train? |
Hi @troystaylor, This will not impact the connectors that are already deployed or being deployed. However, this issue will affect the connectors that have not yet been certified, regardless of whether they are new or update. |
Hi @vmanoharas - unfortunately the api required OAuth2.0, so we will have to wait.
Hi @vmanoharas - unfortunately the api required OAuth2.0, so we will have to wait. Can we at least add improvements to the submitted code in the meantime? Thank you |
Hi @maxhenkentech, The code looks good and swagger validation passed successfully. Please allow us time until this weekend. |
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:
3 Unique Actions:
All Action:
Test Page: