Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ironclad CLM (Independent Publisher) #3709

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

maxhenkentech
Copy link

@maxhenkentech maxhenkentech commented Nov 12, 2024


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • [N/A] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

3 Unique Actions:

image

image

image

All Action:

image

Test Page:

image

@maxhenkentech maxhenkentech requested a review from a team as a code owner November 12, 2024 12:06
@maxhenkentech
Copy link
Author

@microsoft-github-policy-service agree

@maxhenkentech maxhenkentech changed the title Ironclad CLM Independent Publisher Ironclad CLM (Independent Publisher) Nov 12, 2024
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @maxhenkentech,

Please address the review comments and remove the intro.md file which is not needed for Independent Publisher connector.

image

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @maxhenkentech,

Please resolve review comments.

@maxhenkentech
Copy link
Author

maxhenkentech commented Nov 19, 2024

Hello @maxhenkentech,

Please resolve review comments.

Thank you, @vmanoharas! All done.

Added support for Workflow Documents as Array as requested by Ironcald
Added support for Workflow Documents as Array as requested by Ironclad
@maxhenkentech
Copy link
Author

@vmanoharas: Made minor changes to add support for a feature requested by Ironclad

@vmanoharas
Copy link
Contributor

Hello @maxhenkentech,

Thank you!

Could you please update the files with proper indentation? please check the below documentation.

https://learn.microsoft.com/en-us/connectors/custom-connectors/coding-standards#api-definition

@maxhenkentech
Copy link
Author

Hi @vmanoharas - I pushed all json and C# files through a code prettifier. Hope this works for you guys. Let me know if anything else is required

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Partner

I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

@vmanoharas
Copy link
Contributor

[[certify-connector]]

@maxhenkentech
Copy link
Author

Thank you @vmanoharas - do you already have the static callback URL for the connector? Ironclad and I are preparing documentation and would like to include it asap. Thank you 🙏

@vmanoharas
Copy link
Contributor

Thank you @vmanoharas - do you already have the static callback URL for the connector? Ironclad and I are preparing documentation and would like to include it asap. Thank you 🙏

No @maxhenkentech, please include it during this week as it is already approved, our team can take it forward for certification during this week or next week.

@maxhenkentech
Copy link
Author

maxhenkentech commented Dec 2, 2024

Thank you @vmanoharas - do you already have the static callback URL for the connector? Ironclad and I are preparing documentation and would like to include it asap. Thank you 🙏

No @maxhenkentech, please include it during this week as it is already approved, our team can take it forward for certification during this week or next week.

Hi @vmanoharas - we don't really mind what it is. We had understood that MS will assign the static one as indicatd in the apiProperties. Currently we have this:

"redirectMode": "GlobalPerConnector", "redirectUrl": "https://global.consent.azure-apim.net/redirect/ironcladclm",

which is fine ☺️

We appreciate your support! 🙇🏼

@vmanoharas
Copy link
Contributor

Thank you @vmanoharas - do you already have the static callback URL for the connector? Ironclad and I are preparing documentation and would like to include it asap. Thank you 🙏

No @maxhenkentech, please include it during this week as it is already approved, our team can take it forward for certification during this week or next week.

Hi @vmanoharas - we don't really mind what it is. We had understood that MS will assign the static one as indicatd in the apiProperties. Currently we have this:

"redirectMode": "GlobalPerConnector", "redirectUrl": "https://global.consent.azure-apim.net/redirect/ironcladclm",

which is fine ☺️

We appreciate your support! 🙇🏼

Hello @maxhenkentech,

Please refer this link - https://learn.microsoft.com/en-us/connectors/custom-connectors/#21-oauth-20

@maxhenkentech
Copy link
Author

Thank you @vmanoharas - do you already have the static callback URL for the connector? Ironclad and I are preparing documentation and would like to include it asap. Thank you 🙏

No @maxhenkentech, please include it during this week as it is already approved, our team can take it forward for certification during this week or next week.

Hi @vmanoharas - we don't really mind what it is. We had understood that MS will assign the static one as indicatd in the apiProperties. Currently we have this:
"redirectMode": "GlobalPerConnector", "redirectUrl": "https://global.consent.azure-apim.net/redirect/ironcladclm",
which is fine ☺️
We appreciate your support! 🙇🏼

Hello @maxhenkentech,

Please refer this link - https://learn.microsoft.com/en-us/connectors/custom-connectors/#21-oauth-20

Hi @vmanoharas - this is all fine, we just didn't know if anything else is required on the MS side to ensure the GlobalPerConnector callback url is created/can accept callbacks (https://global.consent.azure-apim.net/redirect/ironcladclm). We assume this happens automatically 👍🏻

Thanks!

@maxhenkentech
Copy link
Author

Hi @vmanoharas - hope you had a good start into 2025! We are in week 5 now, so wanted to ask when we can expect the connector to become live? We also cannot yet see the pull in the dev repo, so wanted to ask from when we can make some tweaks to the custom connector? We had some feedback with some minor improvements we wanted to pull.

Thank you ☺️

@vmanoharas
Copy link
Contributor

Hello @maxhenkentech,

Apologies for the delay, and thank you for following up! The deployment was frozen due to the continuous holidays but was lifted this week. We have now started certifying your connector and will provide an update once it has been deployed to all regions.

Thank you for your patience and understanding!

@maxhenkentech
Copy link
Author

Hi @vmanoharas - Any update on this? Thank you!

@maxhenkentech
Copy link
Author

Hi @vmanoharas - Any update on this? Thank you!

Hi @vmanoharas - could you let us know when we can expect the connector to be certified? Thank you!

@vmanoharas
Copy link
Contributor

Hello @maxhenkentech,

Unfortunately, due to the holiday season, there was a deployment freeze from November 20, 2024, to January 6, 2025, followed by another freeze from January 24 to January 31, 2025, due to Lunar New Year.

We are working hard to complete the queue which are lined up in the deployment freeze. This would be deployed to all regions in next 3 to 4 week.

@maxhenkentech
Copy link
Author

Hello @maxhenkentech,

Unfortunately, due to the holiday season, there was a deployment freeze from November 20, 2024, to January 6, 2025, followed by another freeze from January 24 to January 31, 2025, due to Lunar New Year.

We are working hard to complete the queue which are lined up in the deployment freeze. This would be deployed to all regions in next 3 to 4 week.

Hi @vmanoharas - any updates on timelines? Our customers are desperately waiting on the deployment. Thank you!

@vmanoharas
Copy link
Contributor

Hello @maxhenkentech,
Unfortunately, due to the holiday season, there was a deployment freeze from November 20, 2024, to January 6, 2025, followed by another freeze from January 24 to January 31, 2025, due to Lunar New Year.
We are working hard to complete the queue which are lined up in the deployment freeze. This would be deployed to all regions in next 3 to 4 week.

Hi @vmanoharas - any updates on timelines? Our customers are desperately waiting on the deployment. Thank you!

Hi @maxhenkentech,

Unfortunately, we are currently facing an issue with the oAuth IP connectors. Our team is actively working to resolve this issue. In the meantime, if you could switch the connector to API key and basic authentication, it would help expedite the deployment process. If this is not feasible, we will proceed with the deployment once the issue is resolved. We appreciate your patience and understanding during this time.

@troystaylor
Copy link
Contributor

@vmanoharas Can you provide more details for what is the issue with OAuth connector deployment? Is it because they have multiple OAuth configurations? Will this issue affect other connectors on the train?

@vmanoharas
Copy link
Contributor

@vmanoharas Can you provide more details for what is the issue with OAuth connector deployment? Is it because they have multiple OAuth configurations? Will this issue affect other connectors on the train?

Hi @troystaylor,

This will not impact the connectors that are already deployed or being deployed. However, this issue will affect the connectors that have not yet been certified, regardless of whether they are new or update.

@maxhenkentech
Copy link
Author

Hi @vmanoharas - unfortunately the api required OAuth2.0, so we will have to wait.

Hello @maxhenkentech,
Unfortunately, due to the holiday season, there was a deployment freeze from November 20, 2024, to January 6, 2025, followed by another freeze from January 24 to January 31, 2025, due to Lunar New Year.
We are working hard to complete the queue which are lined up in the deployment freeze. This would be deployed to all regions in next 3 to 4 week.

Hi @vmanoharas - any updates on timelines? Our customers are desperately waiting on the deployment. Thank you!

Hi @maxhenkentech,

Unfortunately, we are currently facing an issue with the oAuth IP connectors. Our team is actively working to resolve this issue. In the meantime, if you could switch the connector to API key and basic authentication, it would help expedite the deployment process. If this is not feasible, we will proceed with the deployment once the issue is resolved. We appreciate your patience and understanding during this time.

Hi @vmanoharas - unfortunately the api required OAuth2.0, so we will have to wait. Can we at least add improvements to the submitted code in the meantime? Thank you

@vmanoharas
Copy link
Contributor

Hi @vmanoharas - unfortunately the api required OAuth2.0, so we will have to wait.

Hello @maxhenkentech,
Unfortunately, due to the holiday season, there was a deployment freeze from November 20, 2024, to January 6, 2025, followed by another freeze from January 24 to January 31, 2025, due to Lunar New Year.
We are working hard to complete the queue which are lined up in the deployment freeze. This would be deployed to all regions in next 3 to 4 week.

Hi @vmanoharas - any updates on timelines? Our customers are desperately waiting on the deployment. Thank you!

Hi @maxhenkentech,
Unfortunately, we are currently facing an issue with the oAuth IP connectors. Our team is actively working to resolve this issue. In the meantime, if you could switch the connector to API key and basic authentication, it would help expedite the deployment process. If this is not feasible, we will proceed with the deployment once the issue is resolved. We appreciate your patience and understanding during this time.

Hi @vmanoharas - unfortunately the api required OAuth2.0, so we will have to wait. Can we at least add improvements to the submitted code in the meantime? Thank you

Hi @maxhenkentech,

The code looks good and swagger validation passed successfully. Please allow us time until this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants