Changed WorkflowInfoDatamart type to string to be in alignment with o… #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther WorkflowInfo objects. Deserialization was causing an exception as the class was not structured in alignment with the JSON: JsonSerializationException: Error converting value "Sql" to type 'Microsoft.PowerBI.Api.Models.DatamartType'.
MarkusFleischmann
approved these changes
Nov 3, 2022
|
I had the same issue like you describe, so I try and added my review as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was experiencing a deserialization error when a workspace contained a datamart. This is due to the type object of WorkspaceInfoDatamart not being in alignment with how the JSON is structured. I have converted this type to a string to be in alignment with other objects such as WorkspaceInfoDataset and WorkspaceInfoReport.
NOTE: I did not modify the swagger file so if this change is approved this will need to be done.
Exception Info:
JsonSerializationException: Error converting value "Sql" to type 'Microsoft.PowerBI.Api.Models.DatamartType'.
Question
please answer the following questions. put x inside [ ] (e.g. [x])
What inside?
Is pull request totally generated from swagger file?
Backward compatibility break?
Learn more about backward compatibility.