Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/dowaldma/mirror 3.28 #176

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
6524731
Merged PR 154557: Update Public doc for get users admin APIs
May 4, 2021
2305e46
Merged PR 166160: Export API note for fixing timeout exceptions
KesemSharabi May 9, 2021
ee561c3
Merged PR 165160: Add ALM public APIs
MahirDiab May 24, 2021
51eb25a
Merged PR 173555: Fix class name: PipelineStageArtifactBase
MahirDiab May 24, 2021
25d0d8d
Updated pack-sdk.cmd
MahirDiab May 24, 2021
b051fbc
Merged PR 175163: Improve Update Datasource request documentation
laurent-mic May 31, 2021
8d51cbc
Merged PR 176780: Add dataflows to Alm public endpoints
gilitaragano Jun 15, 2021
50118b0
Merged PR 175298: added alm admin API
TslilD Jun 20, 2021
a5932c9
Merged PR 180660: fixed bold "required" in PipelineUserAccessRight in…
TslilD Jun 22, 2021
55ddc34
Update scanner documentation
eisuissa Jun 23, 2021
fd17b1e
Update swagger subartifacts documentation
eisuissa Jun 24, 2021
d6952d8
Update swagger doc
eisuissa Jun 27, 2021
42ae811
Update minor version to 26
eisuissa Jun 27, 2021
adb8015
Merged PR 180704: Doc bug 1835287
KesemSharabi Jul 5, 2021
bdbdf45
Merged PR 183886: Gateway ID in a gateway cluster
KesemSharabi Jul 6, 2021
0408fa9
Merged PR 184183: createdBy addition
KesemSharabi Jul 7, 2021
aeb7c6a
Merged PR 177806: update the scanner API doc for artifact users
Jul 14, 2021
54c9061
Merged PR 188093: minor version change to add artifactusers to scanne…
Jul 23, 2021
58a8be5
Merged PR 189422: Various REST API doc fixes
laurent-mic Jul 28, 2021
cd86bd9
Merged PR 177898: Add dev suffix to dev package
laurent-mic Jul 28, 2021
59fd925
Merged PR 184242: Datasource type list
KesemSharabi Aug 4, 2021
cb263a2
Merged PR 191371: Fix Code mismatch with Swagger
laurent-mic Aug 10, 2021
1b64a68
Merged PR 193079: Add documentation for dataset ExecuteQueries API
someuser5 Aug 11, 2021
68b9a54
Merged PR 193416: Make ID uppercase
Aug 12, 2021
9f32f0b
Merged PR 189145: adding sample link
dowaldma Aug 15, 2021
0e7597c
Merged PR 196973: Add user artifactAccess admin API
Aug 31, 2021
12ae164
Merged PR 199036: Fix swagger-code mismatch
laurent-mic Sep 1, 2021
6b09664
Merged PR 199064: Add permission level to documentation
eisuissa Sep 1, 2021
2cd572d
Merged PR 199013: adding overrideReport/Model in Import pbix file
dowaldma Sep 3, 2021
06d1749
Merged PR 200958: release version 3.28.0
dowaldma Sep 9, 2021
a82cde4
Merge remote-tracking branch 'External/master' into dev/dowaldma/mirr…
dowaldma Sep 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pipelines/pipeline.user.windows.official.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version:
name: 'sdk version'
major: 3
minor: 23
minor: 28
system: 'Buildrevision'
exclude_commit: true
assembly_version: 'majorminoronly'
Expand Down
2 changes: 1 addition & 1 deletion scripts/pack-sdk-dev.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ if "%VERSION%"=="" SET VERSION=0.0.1111
echo ========================================
echo "Pack PowerBI.Api.csproj Release - AnyCPU..."
echo ========================================
call msbuild %~dp0..\sdk\PowerBI.Api\PowerBI.Api.csproj /t:pack /p:Configuration=Release /p:PackageVersion=%VERSION% /p:PackageOutputPath=%~dp0..\pack\Dev
call msbuild %~dp0..\sdk\PowerBI.Api\PowerBI.Api.csproj /t:pack /p:Configuration=Release /p:PackageVersion=%VERSION%-dev /p:PackageOutputPath=%~dp0..\pack\Dev

set EX=%ERRORLEVEL%
if "%EX%" neq "0" (
Expand Down
70 changes: 70 additions & 0 deletions sdk/PowerBI.Api.Tests/ImportsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,76 @@ public async Task PostImportFileWithNameAndSkipReport()
}
}

[TestMethod]
public async Task PostImportFileWithNameAndNotOverrideReport()
{
var datasetDisplayName = "TestDataset";
var importResponse = CreateSampleImportResponse();
var overrideReportLabel = false;

using (var handler = new FakeHttpClientHandler(importResponse))
using (var client = CreatePowerBIClient(handler))
using (var stream = new MemoryStream())
{
await client.Imports.PostImportWithFileAsync(stream, datasetDisplayName, overrideReportLabel: overrideReportLabel);
var expectedRequesetUrl = $"https://api.powerbi.com/v1.0/myorg/imports?datasetDisplayName={datasetDisplayName}&overrideReportLabel={overrideReportLabel}";
Assert.AreEqual(expectedRequesetUrl, handler.Request.RequestUri.ToString());
}
}

[TestMethod]
public async Task PostImportFileWithNameAndNotOverrideModel()
{
var datasetDisplayName = "TestDataset";
var importResponse = CreateSampleImportResponse();
var overrideModelLabel = false;

using (var handler = new FakeHttpClientHandler(importResponse))
using (var client = CreatePowerBIClient(handler))
using (var stream = new MemoryStream())
{
await client.Imports.PostImportWithFileAsync(stream, datasetDisplayName, overrideModelLabel: overrideModelLabel);
var expectedRequesetUrl = $"https://api.powerbi.com/v1.0/myorg/imports?datasetDisplayName={datasetDisplayName}&overrideModelLabel={overrideModelLabel}";
Assert.AreEqual(expectedRequesetUrl, handler.Request.RequestUri.ToString());
}
}

[TestMethod]
public async Task PostImportFileWithNameAndNotOverrideLabels()
{
var datasetDisplayName = "TestDataset";
var importResponse = CreateSampleImportResponse();
var overrideReportLabel = false;
var overrideModelLabel = false;

using (var handler = new FakeHttpClientHandler(importResponse))
using (var client = CreatePowerBIClient(handler))
using (var stream = new MemoryStream())
{
await client.Imports.PostImportWithFileAsync(stream, datasetDisplayName, overrideReportLabel: overrideReportLabel, overrideModelLabel: overrideModelLabel);
var expectedRequesetUrl = $"https://api.powerbi.com/v1.0/myorg/imports?datasetDisplayName={datasetDisplayName}&overrideReportLabel={overrideReportLabel}&overrideModelLabel={overrideModelLabel}";
Assert.AreEqual(expectedRequesetUrl, handler.Request.RequestUri.ToString());
}
}

[TestMethod]
public async Task PostImportFileWithNameAndOverrideLabels()
{
var datasetDisplayName = "TestDataset";
var importResponse = CreateSampleImportResponse();
var overrideReportLabel = true;
var overrideModelLabel = true;

using (var handler = new FakeHttpClientHandler(importResponse))
using (var client = CreatePowerBIClient(handler))
using (var stream = new MemoryStream())
{
await client.Imports.PostImportWithFileAsync(stream, datasetDisplayName, overrideReportLabel: overrideReportLabel, overrideModelLabel: overrideModelLabel);
var expectedRequesetUrl = $"https://api.powerbi.com/v1.0/myorg/imports?datasetDisplayName={datasetDisplayName}&overrideReportLabel={overrideReportLabel}&overrideModelLabel={overrideModelLabel}";
Assert.AreEqual(expectedRequesetUrl, handler.Request.RequestUri.ToString());
}
}

[TestMethod]
public async Task PostImportWithFileWithNameAndConflictAndSkipReport()
{
Expand Down
40 changes: 32 additions & 8 deletions sdk/PowerBI.Api/Extensions/ImportsOperationsExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,15 @@ public static Imports GetImports(this IImportsOperations operations, Guid groupI
/// <param name='skipReport'>
/// Determines whether to skip report import, if specified value must be 'true'. Only supported for PBIX files.
/// </param>
public static Import PostImport(this IImportsOperations operations, Guid groupId, string datasetDisplayName, ImportInfo importInfo, ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?))
/// <param name='overrideReportLabel'>
/// Determines whether to override existing label on report during republish of PBIX file, service default value is true.
/// </param>
/// <param name='overrideModelLabel'>
/// Determines whether to override existing label on model during republish of PBIX file, service default value is true.
/// </param>
public static Import PostImport(this IImportsOperations operations, Guid groupId, string datasetDisplayName, ImportInfo importInfo, ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), bool? overrideReportLabel = default(bool?), bool? overrideModelLabel = default(bool?))
{
return operations.PostImportAsync(groupId, datasetDisplayName, importInfo, nameConflict, skipReport).GetAwaiter().GetResult();
return operations.PostImportAsync(groupId, datasetDisplayName, importInfo, nameConflict, skipReport, overrideReportLabel, overrideModelLabel).GetAwaiter().GetResult();
}

/// <summary>
Expand All @@ -92,12 +98,18 @@ public static Imports GetImports(this IImportsOperations operations, Guid groupI
/// <param name='skipReport'>
/// Determines whether to skip report import, if specified value must be 'true'. Only supported for PBIX files.
/// </param>
/// <param name='overrideReportLabel'>
/// Determines whether to override existing label on report during republish of PBIX file, service default value is true.
/// </param>
/// <param name='overrideModelLabel'>
/// Determines whether to override existing label on model during republish of PBIX file, service default value is true.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
/// </param>
public static async Task<Import> PostImportAsync(this IImportsOperations operations, Guid groupId, string datasetDisplayName, ImportInfo importInfo, ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), CancellationToken cancellationToken = default(CancellationToken))
public static async Task<Import> PostImportAsync(this IImportsOperations operations, Guid groupId, string datasetDisplayName, ImportInfo importInfo, ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), bool? overrideReportLabel = default(bool?), bool? overrideModelLabel = default(bool?), CancellationToken cancellationToken = default(CancellationToken))
{
using (var _result = await operations.PostImportInGroupWithHttpMessagesAsync(groupId, datasetDisplayName, importInfo, nameConflict, skipReport, null, cancellationToken).ConfigureAwait(false))
using (var _result = await operations.PostImportInGroupWithHttpMessagesAsync(groupId, datasetDisplayName, importInfo, nameConflict, skipReport, overrideReportLabel, overrideModelLabel, null, cancellationToken).ConfigureAwait(false))
{
return _result.Body;
}
Expand Down Expand Up @@ -198,9 +210,15 @@ public static TemporaryUploadLocation CreateTemporaryUploadLocation(this IImport
/// <param name='skipReport'>
/// Determines whether to skip report import, if specified value must be 'true'. Only supported for PBIX files.
/// </param>
public static Import PostImportWithFile(this IImportsOperations operations, Guid groupId, Stream fileStream, string datasetDisplayName = default(string), ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?))
/// <param name='overrideReportLabel'>
/// Determines whether to override existing label on report during republish of PBIX file, service default value is true.
/// </param>
/// <param name='overrideModelLabel'>
/// Determines whether to override existing label on model during republish of PBIX file, service default value is true.
/// </param>
public static Import PostImportWithFile(this IImportsOperations operations, Guid groupId, Stream fileStream, string datasetDisplayName = default(string), ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), bool? overrideReportLabel = default(bool?), bool? overrideModelLabel = default(bool?))
{
return Task.Factory.StartNew(s => ((IImportsOperations)s).PostImportFileWithHttpMessage(groupId, fileStream, datasetDisplayName, nameConflict, skipReport), operations, CancellationToken.None, TaskCreationOptions.None, TaskScheduler.Default).Unwrap().GetAwaiter().GetResult().Body;
return Task.Factory.StartNew(s => ((IImportsOperations)s).PostImportFileWithHttpMessage(groupId, fileStream, datasetDisplayName, nameConflict, skipReport, overrideReportLabel, overrideModelLabel), operations, CancellationToken.None, TaskCreationOptions.None, TaskScheduler.Default).Unwrap().GetAwaiter().GetResult().Body;
}

/// <summary>
Expand All @@ -225,12 +243,18 @@ public static TemporaryUploadLocation CreateTemporaryUploadLocation(this IImport
/// <param name='skipReport'>
/// Determines whether to skip report import, if specified value must be 'true'. Only supported for PBIX files.
/// </param>
/// <param name='overrideReportLabel'>
/// Determines whether to override existing label on report during republish of PBIX file, service default value is true.
/// </param>
/// <param name='overrideModelLabel'>
/// Determines whether to override existing label on model during republish of PBIX file, service default value is true.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
/// </param>
public static async Task<Import> PostImportWithFileAsync(this IImportsOperations operations, Guid groupId, Stream fileStream, string datasetDisplayName = default(string), ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), CancellationToken cancellationToken = default(CancellationToken))
public static async Task<Import> PostImportWithFileAsync(this IImportsOperations operations, Guid groupId, Stream fileStream, string datasetDisplayName = default(string), ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), bool? overrideReportLabel = default(bool?), bool? overrideModelLabel = default(bool?), CancellationToken cancellationToken = default(CancellationToken))
{
using (var _result = await operations.PostImportFileWithHttpMessage(groupId, fileStream, datasetDisplayName, nameConflict, skipReport, null, cancellationToken).ConfigureAwait(false))
using (var _result = await operations.PostImportFileWithHttpMessage(groupId, fileStream, datasetDisplayName, nameConflict, skipReport, overrideReportLabel, overrideModelLabel, null, cancellationToken).ConfigureAwait(false))
{
return _result.Body;
}
Expand Down
16 changes: 14 additions & 2 deletions sdk/PowerBI.Api/Imports/IImportsOperations.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,16 @@ public partial interface IImportsOperations
/// <param name='skipReport'>
/// Determines whether to skip report import, if specified value must be 'true'. Only supported for PBIX files.
/// </param>
/// <param name='overrideReportLabel'>
/// Determines whether to override existing label on report during republish of PBIX file, service default value is true.
/// </param>
/// <param name='overrideModelLabel'>
/// Determines whether to override existing label on model during republish of PBIX file, service default value is true.
/// </param>
/// <param name="customHeaders">Optional custom headers</param>
/// <param name="cancellationToken">Optional cancellation token</param>
/// <returns></returns>
Task<HttpOperationResponse<Import>> PostImportFileWithHttpMessage(Stream file, string datasetDisplayName = default(string), ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
Task<HttpOperationResponse<Import>> PostImportFileWithHttpMessage(Stream file, string datasetDisplayName = default(string), ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), bool? overrideReportLabel = default(bool?), bool? overrideModelLabel = default(bool?), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));

/// <summary>
/// Uploads a PBIX file to the specified group
Expand All @@ -51,12 +57,18 @@ public partial interface IImportsOperations
/// <param name='skipReport'>
/// Determines whether to skip report import, if specified value must be 'true'. Only supported for PBIX files.
/// </param>
/// <param name='overrideReportLabel'>
/// Determines whether to override existing label on report during republish of PBIX file, service default value is true.
/// </param>
/// <param name='overrideModelLabel'>
/// Determines whether to override existing label on model during republish of PBIX file, service default value is true.
/// </param>
/// <param name="customHeaders">
/// Optional custom headers
/// </param>
/// <param name="cancellationToken">
/// Optional cancellation token
/// </param>
Task<HttpOperationResponse<Import>> PostImportFileWithHttpMessage(Guid? groupId, Stream file, string datasetDisplayName = default(string), ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
Task<HttpOperationResponse<Import>> PostImportFileWithHttpMessage(Guid? groupId, Stream file, string datasetDisplayName = default(string), ImportConflictHandlerMode? nameConflict = default(ImportConflictHandlerMode?), bool? skipReport = default(bool?), bool? overrideReportLabel = default(bool?), bool? overrideModelLabel = default(bool?), Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken));
}
}
Loading