prevent 'error IDE0036: Modifiers are not ordered'

[jburnett]

Using build ci at githash 5b4aa54 gives 'error IDE0036: Modifiers are not ordered'

/Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Collections/ControlPropertiesCollection.cs(10,5): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [/Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Microsoft.PowerPlatform.PowerApps.Persistence.csproj] /Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Collections/CustomPropertiesCollection.cs(10,5): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [/Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Microsoft.PowerPlatform.PowerApps.Persistence.csproj] /Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Collections/CustomPropertyParametersCollection.cs(10,5): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [/Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Microsoft.PowerPlatform.PowerApps.Persistence.csproj] /Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Extensions/YamlExtensions.cs(11,5): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [/Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Microsoft.PowerPlatform.PowerApps.Persistence.csproj] /Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/PaYaml/Models/NamedObjectMapping.cs(16,5): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [/Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Microsoft.PowerPlatform.PowerApps.Persistence.csproj] /Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/PaYaml/Models/NamedObjectSequence.cs(12,5): error IDE0036: Modifiers are not ordered (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0036) [/Users/jb/src/github.com/microsoft/PowerApps-Tooling/src/Persistence/Microsoft.PowerPlatform.PowerApps.Persistence.csproj]
0 Warning(s)
6 Error(s)

If this is related to an issue open in GitHub, please link it to this ticket and put the URL here.

Problem

Cloning the repo and following its instructions to build using build ci results in a failed build. The error code indicates an error in the expected order for modifiers.

Solution

Either fix the modifier order of the files identified, or take my change to ignore them.

Changes

• I changed .editorconfig to ignore IDE0036 errors. AFAIK, modifier order does not impact the resulting assembly.

Validation

• Successfully built PA tools w/this small change.

[tehcrashxor]

Looks like the style diagnostic is complaining about occurrences of readonly static which should be static readonly. A better fix would be updating those instances instead of turning off the diagnostic.

[jburnett]

@microsoft-github-policy-service agree

[jburnett]

I resubmitted with changes to field decorator order as suggested.