Changes to address gallery style issue. #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochuk
approved these changes
Jul 23, 2024
tehcrashxor
approved these changes
Jul 25, 2024
Co-authored-by: Crash Collison <[email protected]>
tehcrashxor
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is related to an issue open in GitHub, please link it to this ticket and put the URL here.
Problem
What is the issue we are attempting to solve?
In the case of the gallery control, there is a nested template that needs to be available before the children control for gallery are created. The nested template is used to provide information about the data control that the gallery needs to use. Changes to add nested children first. Validate change in test case.
Solution
What are we doing to solve this issue?
Add the nested templates before the control children are added.
Changes
Validation