Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning that repeatedly shows up #7731

Merged
merged 33 commits into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
2e9060c
update versions exposed to users
StellaHuang95 Oct 5, 2022
aa8bc3a
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Oct 6, 2022
cecb2b8
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Oct 12, 2022
d031333
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Oct 26, 2022
bd5fb49
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Nov 2, 2022
e63f5c4
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Nov 23, 2022
b02e817
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Dec 5, 2022
2001ceb
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Jan 9, 2023
c07a4ea
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Feb 1, 2023
833e204
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Feb 8, 2023
eefe818
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Feb 24, 2023
050b463
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Mar 3, 2023
790aab3
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Mar 7, 2023
6f6c5e4
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Mar 8, 2023
309d646
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Mar 22, 2023
e3c538f
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Mar 30, 2023
01faa43
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Apr 3, 2023
797497e
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Apr 19, 2023
9d22f1a
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Apr 24, 2023
10ac513
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Apr 26, 2023
0476427
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 May 9, 2023
4ac859d
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 May 9, 2023
c2d1322
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 May 22, 2023
12d78d2
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Jun 8, 2023
6e5798c
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Jun 29, 2023
1cff311
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Jul 13, 2023
dfa7a9e
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Aug 23, 2023
bd90c9b
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Sep 1, 2023
3ff6f79
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Sep 14, 2023
7fa6915
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Sep 26, 2023
a141584
Merge branch 'main' of https://github.com/Microsoft/PTVS
StellaHuang95 Sep 28, 2023
1ce0b7f
fix warning repeatedly showing up
StellaHuang95 Oct 12, 2023
c6aeb95
update debugpy version
StellaHuang95 Oct 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Build/debugpy-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.6.7
1.8.0
Original file line number Diff line number Diff line change
Expand Up @@ -396,18 +396,6 @@ private LanguageServerSettings.PythonSettings GetSettings(Uri scopeUri = null)
PythonConstants.TypeCheckingModeSetting, null, Site, PythonWorkspaceContextProvider.Workspace, out _)
?? _analysisOptions.TypeCheckingMode;

var ver3 = new Version(3, 0);
var version = context.InterpreterConfiguration.Version;
// show a warning if the python version is not supported
if (version.ToLanguageVersion() == PythonLanguageVersion.None)
{
MessageBox.ShowWarningMessage(Site, Strings.PythonVersionNotSupportedInfoBarText.FormatUI(context.InterpreterConfiguration.Description));
}
else if (context.InterpreterConfiguration.Version < ver3)
{
MessageBox.ShowWarningMessage(Site, Strings.WarningPython2NotSupported);
}

// get task list tokens from options
var taskListTokens = new List<LanguageServerSettings.PythonSettings.PythonAnalysisSettings.TaskListToken>();
var taskListService = Site.GetService<SVsTaskList, ITaskList>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
using Microsoft.Build.Execution;
using Microsoft.PythonTools.Commands;
using Microsoft.PythonTools.Common;
using Microsoft.PythonTools.Common.Parsing;
using Microsoft.PythonTools.Environments;
using Microsoft.PythonTools.Infrastructure;
using Microsoft.PythonTools.Interpreter;
Expand Down Expand Up @@ -273,6 +274,14 @@ internal set {
MSBuildConstants.InterpreterIdProperty,
ReplaceMSBuildPath(_active.Configuration.Id)
);
var ver3 = new Version(3, 0);
var version = _active.Configuration.Version;
// show a warning if the python version is not supported
if (version.ToLanguageVersion() == PythonLanguageVersion.None) {
Utility.MessageBox.ShowWarningMessage(Site, Strings.PythonVersionNotSupportedInfoBarText.FormatUI(_active.Configuration.Description));
} else if (_active.Configuration.Version < ver3) {
Utility.MessageBox.ShowWarningMessage(Site, Strings.WarningPython2NotSupported);
}
} else {
BuildProject.SetProperty(MSBuildConstants.InterpreterIdProperty, "");
}
Expand Down