-
Notifications
You must be signed in to change notification settings - Fork 100
make sqrt_Fp2 work for subfield elements #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@yyyyx4 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Currently,
sqrt_Fp2always returns0when the given element is a non-square in 𝔽ₚ.This patch adds a special code path for square roots of subfield elements which handles this special case correctly.