Skip to content

Conversation

@Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Nov 17, 2025

Updates API docs infra to accommodate API changes in the library. Most notably: custom transformation logic now targets mdast directly, rather than the bespoke documentation tree representation that has been removed from the library.

@github-actions github-actions bot added area: website base: main PRs targeted against main branch labels Nov 17, 2025
throw new Error("Expected an HTML element as output from table node transformation.");
}

htmlTree.properties.class = "table table-striped table-hover";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: we were previously transforming tables directly to HTML so we could inject these styling properties, but they were not being respected to begin with. If we wish to add table hover behavior, we will want to implement that using standard styling practices.

@Josmithr Josmithr requested a review from a team November 17, 2025 23:48
@Josmithr Josmithr marked this pull request as ready for review November 17, 2025 23:48
@github-actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  243823 links
    1778 destination URLs
    2015 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: website base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant