Testing frozen container #25603
Merged
Testing frozen container #25603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the loadFrozenContainerFromPendingState functionality. It refactors the existing test by extracting an initialization function and adds three new test cases to verify frozen container behavior.
- Refactored existing test by extracting a reusable
initialize()function for setup - Added test coverage for loading DDS (Distributed Data Structures) from frozen containers
- Added test coverage for blob handling in frozen containers, including upload restrictions
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| loadFrozenContainerFromPendingState.spec.ts | Refactored initialization logic and added three new test cases for frozen container functionality |
| package.json | Added @fluid-internal/client-utils dependency for buffer/string conversion utilities |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| isFluidHandle(value) ? toFluidHandleInternal(value).absolutePath : value, | ||
| ]); | ||
|
|
||
| // initialize loader and create a container function |
There was a problem hiding this comment.
[nitpick] The comment 'initialize loader and create a container function' is unclear. Consider changing to 'Initialize test environment and create a container' to better describe what the function does.
Suggested change
| // initialize loader and create a container function | |
| // Initialize test environment and create a container |
anthony-murphy
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that exclusively adds more testing to frozen container. It adds the same tests as #25562 solving comments on that PR by adding an initialization function and removing the snapshot refresh change.