Skip to content

[NFC] Remove assert from SPV Work Graphs #8599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
llvm-beanz merged 2 commits into from
Jul 1, 2026
+0 −13
Merged

[NFC] Remove assert from SPV Work Graphs #8599

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4991a22
[NFC] Don't string match WG type names
llvm-beanz Jul 1, 2026
65d69cc
Remove IsHLSLNodeRecordArrayType
llvm-beanz Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions tools/clang/lib/AST/HlslTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,14 +604,9 @@ bool IsHLSLNodeOutputType(clang::QualType type) {
}

bool IsHLSLNodeRecordArrayType(clang::QualType type) {
if (const RecordType *RT = type->getAs<RecordType>()) {
StringRef name = RT->getDecl()->getName();
if (name == "ThreadNodeOutputRecords" || name == "GroupNodeOutputRecords" ||
name == "GroupNodeInputRecords" || name == "RWGroupNodeInputRecords" ||
name == "EmptyNodeInput")
return true;
}
return false;
return ((static_cast<uint32_t>(GetNodeIOType(type)) &
static_cast<uint32_t>(DXIL::NodeIOFlags::NodeArray)) ==
static_cast<uint32_t>(DXIL::NodeIOFlags::NodeArray));
}

bool IsHLSLEmptyNodeRecordType(clang::QualType type) {
Expand Down
Loading