Prevent experimental RDAT on released shader targets (#8534)#8589
Merged
damyanp merged 1 commit intoJun 29, 2026
Merged
Conversation
This will prevent experimental RDAT parts from being emitted when compiling to a released shader target, unless you explicitly supply -validator-version 0.0. - Add experimental DXIL version detection. - Update MaxPartTypeForValVer to require prerelease shader model + experimental validator version or unbound validator version for experimental parts. - DxilRDATBuilder: separate Add/Get to avoid on-demand addition of parts to enforce strict versioning. - Add max validator version to RDAT_STRUCT_TABLE_DERIVED to automatically set table stride correctly. - Add experimental RDAT tests for release and experimental versions. Fixes microsoft#8272
llvm-beanz
approved these changes
Jun 25, 2026
llvm-beanz
left a comment
llvm-beanz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, one question below as a sanity check.
|
|
||
| LastPlus1, | ||
| LastExperimental = LastPlus1 - 1, | ||
| LastRelease = Last_1_8, |
Collaborator
There was a problem hiding this comment.
Just confirming, we didn't change anything in RDAT in 1.9 right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will prevent experimental RDAT parts from being emitted when compiling to a released shader target, unless you explicitly supply -validator-version 0.0.
Fixes #8272
Cherry-pick of 0786300