Skip to content

Fixing long vectors tests to use wide chars for text#8082

Closed
bfavela wants to merge 2 commits into
microsoft:mainfrom
bfavela:bfavela/longvectors_wide_char_fix
Closed

Fixing long vectors tests to use wide chars for text#8082
bfavela wants to merge 2 commits into
microsoft:mainfrom
bfavela:bfavela/longvectors_wide_char_fix

Conversation

@bfavela

@bfavela bfavela commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

I'm not sure if this is related to using a newer VC++ compiler (VS 2022 - 14.44.35207), but I got a compile failure locally without this fix. Looking at the other uses of these macros, I believe this the intended usage in any case.

@github-actions

github-actions Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

✅ With the latest revision this PR passed the C/C++ code formatter.

@bfavela

bfavela commented Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company=AMD

@damyanp

damyanp commented Jan 20, 2026

Copy link
Copy Markdown
Member

Hi Brian!

We're intentionally moving more towards non-wide strings here.

This is likely indicative of you using an extremely old, unsupported, version of TAEF that some older scripts downloaded automatically. See #7888.

@damyanp damyanp closed this Jan 20, 2026
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Jan 20, 2026
@bfavela

bfavela commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

Heya!

Yep, tried to be fancy and use 'winget', but looks like it's an ancient version that gets installed if you don't specify one:

> winget search wdk
Name                                         Id                              Version         Match          Source
------------------------------------------------------------------------------------------------------------------
Windows Driver Kit                           Microsoft.WindowsWDK.10.0.19041 10.1.19041.685                 winget

Fun!

@bfavela bfavela deleted the bfavela/longvectors_wide_char_fix branch January 21, 2026 15:54
@damyanp

damyanp commented Jan 21, 2026

Copy link
Copy Markdown
Member

Ah, thanks for following up, that's unfortunate! Interestingly, I get different results when I search for WDK:

> winget search wdk
Name                                         Id                              Version         Match          Source
------------------------------------------------------------------------------------------------------------------
Windows Driver Kit                           Microsoft.WindowsWDK.10.0.19041 10.1.19041.685                 winget
Windows Driver Kit - Windows 10.1.22000.1    Microsoft.WindowsWDK.10.0.22000 10.1.22000.1                   winget
Windows Driver Kit - Windows 10.0.22621.2428 Microsoft.WindowsWDK.10.0.22621 10.1.22621.2428                winget
Windows Driver Kit - Windows 10.0.26100.6584 Microsoft.WindowsWDK.10.0.26100 10.1.26100.6584                winget
HexChat                                      HexChat.HexChat                 2.16.2          Tag: xchat-wdk winget

@bfavela

bfavela commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

Oh, that's what I get, too. I just installed the default version without looking at the list. I didn't realize TAEF was required for building the source, thought it was just used for running the tests themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants