NFC: hctdb.py Remove manual DXIL op numbering#7892
Merged
Conversation
V-FEXrt
approved these changes
Nov 11, 2025
bogner
approved these changes
Nov 12, 2025
bogner
left a comment
bogner
left a comment
Collaborator
There was a problem hiding this comment.
Minor suggestion below, but LGTM either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change has no impact on any code generated by hctdb.py, used when building DXC.
This change simplifies DXIL operation definitions by removing the need to manually track the OpCode number for each operation. They must be dense, so manually incrementing and supplying the counter could only be a source of error.
This keeps the version markers with the explicit counts which helps prevent changes to ops in previously released dxil versions from accidentally being made and going unnoticed.
This is a simplification meant to ease future experimental DXIL op changes.