NFC: Report error on dxc --version instead of error on None group#7505
Open
tex3d wants to merge 2 commits into
Open
NFC: Report error on dxc --version instead of error on None group#7505tex3d wants to merge 2 commits into
tex3d wants to merge 2 commits into
Conversation
llvm-beanz
approved these changes
Jul 11, 2025
bogner
approved these changes
Sep 17, 2025
llvm-beanz
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds better error handling for
dxc --versionused to get the dxil version in tools/clang/test/lit.cfg in case the dxc call fails.