-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Use enhanced barriers on multithreading sample #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use enhanced barriers on multithreading sample #935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the D3D12Multithreading sample to support enhanced barriers, a newer Direct3D 12 feature that provides more explicit control over resource synchronization. The sample now supports both legacy and enhanced barrier modes through build configurations.
- Adds new build configurations for Enhanced Barriers and renames existing ones to Legacy Barriers
- Upgrades Direct3D 12 interfaces to ID3D12Device10 and ID3D12GraphicsCommandList8
- Implements enhanced barrier API calls with preprocessor guards for conditional compilation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| FrameResource.h | Updates device parameter to ID3D12Device10 and command list array to ID3D12GraphicsCommandList8 |
| FrameResource.cpp | Implements enhanced barrier resource creation and synchronization for shadow textures and constant buffers |
| D3D12Multithreading.vcxproj | Adds new build configurations with USE_ENHANCED_BARRIERS preprocessor definition |
| D3D12Multithreading.sln | Updates solution configurations to support both enhanced and legacy barrier builds |
| D3D12Multithreading.h | Updates device interface to ID3D12Device10 |
| D3D12Multithreading.cpp | Adds enhanced barrier support for all resources and transitions, includes feature detection |
| readme.md | Documents the new enhanced barriers feature and configuration options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated Multithreading sample to use enhanced barriers.
To enable it, choose
<Config Option> (Enhanced Barriers)under the configuration dropdown.